repo
stringclasses
200 values
pull_number
int64
13
143k
instance_id
stringlengths
12
47
issue_numbers
listlengths
1
7
base_commit
stringlengths
40
40
patch
stringlengths
354
98.3k
test_patch
stringlengths
137
8.74M
problem_statement
stringlengths
142
63.8k
hints_text
stringlengths
2
70.5k
all_hints_text
stringlengths
2
70.5k
commit_urls
listlengths
1
119
created_at
timestamp[s]date
2015-04-16 11:31:38
2025-12-17 10:26:03
version
stringclasses
196 values
language
stringclasses
10 values
mikro-orm/mikro-orm
6,642
mikro-orm__mikro-orm-6642
[ 5361, 6641 ]
adc4bf682cd42ac83c71619f62029a86d48b31e1
diff --git a/packages/core/src/decorators/Embedded.ts b/packages/core/src/decorators/Embedded.ts index f78f7489acea..963c42ba5fa8 100644 --- a/packages/core/src/decorators/Embedded.ts +++ b/packages/core/src/decorators/Embedded.ts @@ -1,15 +1,16 @@ -import type { AnyEntity, EntityKey, EntityProperty } from '../typings'...
diff --git a/tests/features/embeddables/GH5361.test.ts b/tests/features/embeddables/GH5361.test.ts new file mode 100644 index 000000000000..2accb5651e22 --- /dev/null +++ b/tests/features/embeddables/GH5361.test.ts @@ -0,0 +1,190 @@ +import { + Embeddable, + Embedded, + Entity, + EntitySchema, + IntegerType, + Mi...
Add support for Embedded column name **Is your feature request related to a problem? Please describe.** Currently it is possible to define the name of a column to be different from the name of the ts/js field ```ts @Property({ name: 'n' }) name!: string; ``` It is also possible to define an embedded object ...
Hmm I would say this should be already working. Maybe I'm not looking at the right place but this is the definition for `EmbeddedOptions`: ```ts export type EmbeddedOptions = { entity?: string | (() => AnyEntity | AnyEntity[]); type?: string; prefix?: string | boolean; nullable?: boolean; obj...
Hmm I would say this should be already working. Maybe I'm not looking at the right place but this is the definition for `EmbeddedOptions`: ```ts export type EmbeddedOptions = { entity?: string | (() => AnyEntity | AnyEntity[]); type?: string; prefix?: string | boolean; nullable?: boolean; obj...
[ "https://github.com/mikro-orm/mikro-orm/commit/f18c88fe761f536cbf8d14b417bab0c06a973374" ]
2025-05-06T16:37:43
0.0
TypeScript
mikro-orm/mikro-orm
6,053
mikro-orm__mikro-orm-6053
[ 6031, 6502, 6503 ]
612d47dc4d2c6b3cb6243f2b869f3e57c4d5567f
diff --git a/packages/core/src/EntityManager.ts b/packages/core/src/EntityManager.ts index 6388ed516581..0ed9253bdecb 100644 --- a/packages/core/src/EntityManager.ts +++ b/packages/core/src/EntityManager.ts @@ -1959,6 +1959,13 @@ export class EntityManager<Driver extends IDatabaseDriver = IDatabaseDriver> { return...
diff --git a/tests/features/dataloader/GH6031.test.ts b/tests/features/dataloader/GH6031.test.ts index 206a4063dba4..500da02e367d 100644 --- a/tests/features/dataloader/GH6031.test.ts +++ b/tests/features/dataloader/GH6031.test.ts @@ -1,14 +1,7 @@ -import { - Collection, - Entity, - ManyToMany, - MikroORM, - Prima...
Dataloader failure with ManyToMany relationship ### Describe the bug With a simple many to many relationship on an entity like this: ``` @ManyToMany(() => Country) countries = new Collection<Country>(this); ``` Enabling dataloader to load this collection with e.g. `await user.countries.load({dataloader: ...
The problem is specifically a unidirectional M:N relation, if you add the inverse side it works fine. @darkbasic could you look into this please? > The problem is specifically a unidirectional M:N relation, if you add the inverse side it works fine I think that's exactly what's going on. I will further look into ...
The problem is specifically a unidirectional M:N relation, if you add the inverse side it works fine. @darkbasic could you look into this please? > The problem is specifically a unidirectional M:N relation, if you add the inverse side it works fine I think that's exactly what's going on. I will further look into ...
[ "https://github.com/mikro-orm/mikro-orm/commit/9361e77baa31ee5398637a2050975fd84fb07477", "https://github.com/mikro-orm/mikro-orm/commit/5780829780448e135286e26a86076cca5ea03823", "https://github.com/mikro-orm/mikro-orm/commit/6f3aa323a860804fc7bcb8a9602b2bd9b6cb1a26", "https://github.com/mikro-orm/mikro-orm/...
2024-09-22T11:22:00
0.0
TypeScript
mikro-orm/mikro-orm
4,872
mikro-orm__mikro-orm-4872
[ 4868 ]
e27e4b907154933feba985badd4f6a60dee06317
diff --git a/packages/core/src/EntityManager.ts b/packages/core/src/EntityManager.ts index c2d3a991fda2..4604654b7dd1 100644 --- a/packages/core/src/EntityManager.ts +++ b/packages/core/src/EntityManager.ts @@ -710,6 +710,7 @@ export class EntityManager<D extends IDatabaseDriver = IDatabaseDriver> { fields: re...
diff --git a/tests/features/read-replicas.test.ts b/tests/features/read-replicas.test.ts index 95df66a1232c..da511cd18b23 100644 --- a/tests/features/read-replicas.test.ts +++ b/tests/features/read-replicas.test.ts @@ -123,6 +123,20 @@ describe('read-replicas', () => { expect(mock.mock.calls[7][0]).toMatch(/begi...
upsert is using read replica for select **Describe the bug** When using `em.upsert()` with read replicas and `preferReadReplicas: true`. The select query that follows the insert query uses the read connections. Probably due to replication lag the hydration fails. I tried setting `preferReadReplicas: false` and it work...
I tried to debug it, and it works as expected when I add.` connectionType: 'write'` [here](https://github.com/mikro-orm/mikro-orm/blob/22e140e986420105c1b5941aae92a7bca1be6fef/packages/core/src/EntityManager.ts#L710-L712), but I am not sure if this is the right fix. Yes, that place looks good, also the same will need t...
I tried to debug it, and it works as expected when I add.` connectionType: 'write'` [here](https://github.com/mikro-orm/mikro-orm/blob/22e140e986420105c1b5941aae92a7bca1be6fef/packages/core/src/EntityManager.ts#L710-L712), but I am not sure if this is the right fix. Yes, that place looks good, also the same will need t...
[ "https://github.com/mikro-orm/mikro-orm/commit/8ce03354f0e4fee917f822db1f2ac8ac98c74228", "https://github.com/mikro-orm/mikro-orm/commit/c47e2b76e7a8dc3f032ff84077c94547a0cdd474" ]
2023-10-23T16:56:01
0.0
TypeScript
mikro-orm/mikro-orm
6,186
mikro-orm__mikro-orm-6186
[ 6179 ]
2e1621c89c208b483f7e3d4a8d22a9622ed697dd
diff --git a/packages/core/src/serialization/EntitySerializer.ts b/packages/core/src/serialization/EntitySerializer.ts index 936d83531a36..8349abd8cf88 100644 --- a/packages/core/src/serialization/EntitySerializer.ts +++ b/packages/core/src/serialization/EntitySerializer.ts @@ -8,6 +8,7 @@ import type { EntityDTOPro...
diff --git a/tests/features/custom-types/GH6179.test.ts b/tests/features/custom-types/GH6179.test.ts new file mode 100644 index 000000000000..9fc1be7203cb --- /dev/null +++ b/tests/features/custom-types/GH6179.test.ts @@ -0,0 +1,72 @@ +import { MikroORM, serialize, wrap } from '@mikro-orm/better-sqlite'; + +import { En...
Serialization with forceObject: true does not apply primary key custom type ### Describe the bug Serialization using `forceObject: true` doesn't apply custom type on foreign key. ### Reproduction ```ts import { MikroORM, serialize, Entity, ManyToOne, Platform, PrimaryKey, Property, Ref, Type } from '@mikro...
Note that this has nothing to do with `forceObject`. I've simplified your repro and inlined it here to the issue description. I've submitted a new [PR](https://github.com/mikro-orm/mikro-orm/pull/6186) to fix this issue (tests pass but I don't have the bigger picture though on if it might have side-effects)
[ "https://github.com/mikro-orm/mikro-orm/commit/0cca5319e838a6cc9d2aa9e3d458b17e26f8d11d", "https://github.com/mikro-orm/mikro-orm/commit/98fda313117d18a9a508af7671cdcfd61bd6ceb2", "https://github.com/mikro-orm/mikro-orm/commit/2e3b4771f123ab359f988cb7c5f314d6283f9394", "https://github.com/mikro-orm/mikro-orm/...
2024-10-23T13:53:17
0.0
TypeScript
mikro-orm/mikro-orm
6,902
mikro-orm__mikro-orm-6902
[ 6885 ]
467e31ff8c0eb7c95342d1b0e60ccb7305908681
diff --git a/packages/core/src/hydration/ObjectHydrator.ts b/packages/core/src/hydration/ObjectHydrator.ts index 587c8993f2f9..5f62e27964ee 100644 --- a/packages/core/src/hydration/ObjectHydrator.ts +++ b/packages/core/src/hydration/ObjectHydrator.ts @@ -89,7 +89,13 @@ export class ObjectHydrator extends Hydrator { ...
diff --git a/tests/features/lazy-scalar-properties/GH6885.test.ts b/tests/features/lazy-scalar-properties/GH6885.test.ts new file mode 100644 index 000000000000..cf3f5c56a228 --- /dev/null +++ b/tests/features/lazy-scalar-properties/GH6885.test.ts @@ -0,0 +1,176 @@ +import { + MikroORM, + Entity, + Property, + Prim...
Lazy property with nullable ScalarRef does not initialize when value is `null` ### Describe the bug When attempting to use a lazy scalar reference that can possibly be nullable, calling `load()` or attempting to populate the field does not initialize the field and results in `undefined` if the resolved value is `null`....
In investigation, I'm wondering if the issue is here? https://github.com/mikro-orm/mikro-orm/blob/467e31ff8c0eb7c95342d1b0e60ccb7305908681/packages/core/src/hydration/ObjectHydrator.ts#L144-L149 If the value is `null`, then this check fails and re-assigns the value to being an uninitialized ScalarReference. However, I...
In investigation, I'm wondering if the issue is here? https://github.com/mikro-orm/mikro-orm/blob/467e31ff8c0eb7c95342d1b0e60ccb7305908681/packages/core/src/hydration/ObjectHydrator.ts#L144-L149 If the value is `null`, then this check fails and re-assigns the value to being an uninitialized ScalarReference. However, I...
[ "https://github.com/mikro-orm/mikro-orm/commit/af2975cd035059c775b1f1fa3b6acb05d0d00d0d", "https://github.com/mikro-orm/mikro-orm/commit/1fe6c28811fc03296f8be50dbde105df8928e095", "https://github.com/mikro-orm/mikro-orm/commit/edd0fcedea431c1e0629176186f64fc634101157", "https://github.com/mikro-orm/mikro-orm/...
2025-10-02T17:21:34
0.0
TypeScript
wevm/viem
635
wevm__viem-635
[ 634 ]
2695f0d26de3331e7fc259071034c7560cca3f1d
diff --git a/src/utils/unit/parseUnits.ts b/src/utils/unit/parseUnits.ts index 5b07a386a2..2accc74dd2 100644 --- a/src/utils/unit/parseUnits.ts +++ b/src/utils/unit/parseUnits.ts @@ -17,7 +17,7 @@ export function parseUnits(value: `${number}`, decimals: number) { fraction.slice(decimals), ] fraction = ...
diff --git a/src/utils/unit/parseUnits.test.ts b/src/utils/unit/parseUnits.test.ts index f5951e2787..218c96c15a 100644 --- a/src/utils/unit/parseUnits.test.ts +++ b/src/utils/unit/parseUnits.test.ts @@ -9,10 +9,14 @@ test('converts number to unit of a given length', () => { expect(parseUnits('20', 9)).toMatchInlineS...
bug: `parseUnits` strips leading zero's of the factional causing wrong results ### Is there an existing issue for this? - [X] I have searched the existing issues ### Package Version 0.3.43 ### Current Behavior `parseUnits("630.0056882018259", 6)` results in `6305688n` ### Expected Behavior `parseUnits("630.0...
Thanks! Fixed in `0.3.49`. Hey, seems like the error was reintroduced ? I'm on `"viem": "^1.0.2"` and running: ```js const decimal = 1.0536059576998882; const bn = Number(parseUnits(`${decimal}`, 7)); console.log(decimal); console.log(bn); console.log(bn / 1e7); ``` outputs: ``` 1.0536059576998882 1536060 0...
[ "https://github.com/wevm/viem/commit/b79eaa6a6563e33f67cd352b108a3f2ef260b119" ]
2023-06-01T21:07:00
1.0
TypeScript
wevm/viem
383
wevm__viem-383
[ 382 ]
d19791425aac446651467c73a8b2273584892b86
diff --git a/.changeset/two-ties-sort.md b/.changeset/two-ties-sort.md new file mode 100644 index 0000000000..e5292d7b0c --- /dev/null +++ b/.changeset/two-ties-sort.md @@ -0,0 +1,5 @@ +--- +"viem": patch +--- + +Fixed an issue where `serializeTransaction` was incorrectly encoding zero-ish properties. diff --git a/src/...
diff --git a/src/utils/transaction/serializeTransaction.test.ts b/src/utils/transaction/serializeTransaction.test.ts index a1202e886c..0a1a49afac 100644 --- a/src/utils/transaction/serializeTransaction.test.ts +++ b/src/utils/transaction/serializeTransaction.test.ts @@ -41,6 +41,28 @@ describe('eip1559', () => { }...
bug: Unable to send transaction with 0 as nonce ### Is there an existing issue for this? - [X] I have searched the existing issues ### Package Version 0.3.2 ### Current Behavior When using a newly created privateKey with funds directly sent to it using a faucet, I'm unable to send any transaction due to ...
After a bit a digging, looks like if I force `nonce` to be `undefined` instead of `0` in a custom account the transaction will work as expected. My guess is that it's related to something over there : https://github.com/wagmi-dev/viem/blob/630f9cc34e9618041a766ef3e5a110165accbf4a/src/utils/transaction/serializeTransact...
After a bit a digging, looks like if I force `nonce` to be `undefined` instead of `0` in a custom account the transaction will work as expected. My guess is that it's related to something over there : https://github.com/wagmi-dev/viem/blob/630f9cc34e9618041a766ef3e5a110165accbf4a/src/utils/transaction/serializeTransact...
[ "https://github.com/wevm/viem/commit/338e15c4fddc6c0dda604b1c1ff04236699a7a87", "https://github.com/wevm/viem/commit/26b781b83d3c245ea6b09e972f14285bb5f2c544", "https://github.com/wevm/viem/commit/4b70ac2cd805c573fffb517faa9368482a4d9abf", "https://github.com/wevm/viem/commit/94b9f36918dac05e35671a35ef4e6a708...
2023-04-17T16:23:49
1.0
TypeScript
wevm/viem
1,657
wevm__viem-1657
[ 1655 ]
038d8debd4c22f1bb16c6b6b9466e4886ede2f97
diff --git a/.changeset/serious-drinks-hammer.md b/.changeset/serious-drinks-hammer.md new file mode 100644 index 0000000000..e0eb71edc8 --- /dev/null +++ b/.changeset/serious-drinks-hammer.md @@ -0,0 +1,5 @@ +--- +"viem": patch +--- + +Fixed `writeContract` `args` type inference. diff --git a/src/actions/wallet/writeC...
diff --git a/src/actions/wallet/writeContract.test-d.ts b/src/actions/wallet/writeContract.test-d.ts index 04115ced6a..4717d2301e 100644 --- a/src/actions/wallet/writeContract.test-d.ts +++ b/src/actions/wallet/writeContract.test-d.ts @@ -8,6 +8,7 @@ import { walletClientWithAccount } from '~test/src/utils.js' import ...
bug: args typing regression ### Is there an existing issue for this? - [X] I have searched the existing issues ### Package Version 2.0.3 ### Current Behavior since `2.0.0`, `args` property type is inferred to `unknown[]` instead of the correct type. ### Expected Behavior `args` should be inferred to `[number]` i...
Will take a look. In addition, your minimal reproduction ABI doesn't have any payable or nonpayable functions. @tmm good point. This is just an error in the example, it doesn’t infer types properly with write function either.
Will take a look. In addition, your minimal reproduction ABI doesn't have any payable or nonpayable functions. @tmm good point. This is just an error in the example, it doesn’t infer types properly with write function either. This issue has been locked since it has been closed for more than 14 days. If you found a con...
[ "https://github.com/wevm/viem/commit/30024e2cfcaf627e5b5394190bf1d1e96c824679", "https://github.com/wevm/viem/commit/00961a54750172abf2051c2f2358b89539bfa510", "https://github.com/wevm/viem/commit/ae1b5bc49b2ec8fd428395b14a95acc278f0c166" ]
2024-01-08T20:32:04
1.0
TypeScript
wevm/viem
1,339
wevm__viem-1339
[ 1336 ]
a9c14e40d7d23f1b18e1899ac252dafc2c4717e9
diff --git a/.changeset/plenty-meals-visit.md b/.changeset/plenty-meals-visit.md new file mode 100644 index 0000000000..462ae4137e --- /dev/null +++ b/.changeset/plenty-meals-visit.md @@ -0,0 +1,5 @@ +--- +"viem": patch +--- + +Fixed topics mismatch in `decodeEventLogs` strict mode. diff --git a/src/utils/abi/decodeEve...
diff --git a/src/actions/public/getFilterChanges.test.ts b/src/actions/public/getFilterChanges.test.ts index 67c0fe20cf..2aa6c4948d 100644 --- a/src/actions/public/getFilterChanges.test.ts +++ b/src/actions/public/getFilterChanges.test.ts @@ -356,7 +356,7 @@ describe('contract events', () => { 'Transfer' ...
decodeEventLog in strict: true mode fails to enforce ABI conformity on indexed arguments ### Is there an existing issue for this? - [X] I have searched the existing issues ### Package Version ^1.15.1 ### Current Behavior I've encountered an issue where `decodeEventLog` when used with `strict: true` is no...
I might just misunderstand how indexed args are supposed to behave, in which case feel free to close :) What’s your ABI? NounsAuctionHouse https://etherscan.io/address/0xf15a943787014461d94da08ad4040f79cd7c124e#code Nice catch! PR here: https://github.com/wagmi-dev/viem/pull/1339
I might just misunderstand how indexed args are supposed to behave, in which case feel free to close :) What’s your ABI? NounsAuctionHouse https://etherscan.io/address/0xf15a943787014461d94da08ad4040f79cd7c124e#code Nice catch! PR here: https://github.com/wagmi-dev/viem/pull/1339 This issue has been locked since it ha...
[ "https://github.com/wevm/viem/commit/80f50a4b96661a05d12ee985f76c3be26e257357", "https://github.com/wevm/viem/commit/6271ebe9212a47d738a35cd25fca020e263275b6" ]
2023-10-12T00:11:55
1.0
TypeScript
wevm/viem
198
wevm__viem-198
[ 180, 197 ]
b9778b0d29b81654e6741a014c0b2213c6f34587
diff --git a/.changeset/warm-jokes-dress.md b/.changeset/warm-jokes-dress.md new file mode 100644 index 0000000000..364d1aaeca --- /dev/null +++ b/.changeset/warm-jokes-dress.md @@ -0,0 +1,5 @@ +--- +"viem": patch +--- + +Added an assertion in `decodeEventLog` to check for a mismatch between topics + indexed event para...
diff --git a/src/errors/abi.test.ts b/src/errors/abi.test.ts index db20149920..38dfb5d8a3 100644 --- a/src/errors/abi.test.ts +++ b/src/errors/abi.test.ts @@ -1,8 +1,9 @@ -import { expect, test } from 'vitest' +import { describe, expect, test } from 'vitest' import { AbiDecodingDataSizeInvalidError, AbiEncodingA...
bug: decodeEventLog topics type error when cycling getLogs data ### Is there an existing issue for this? - [X] I have searched the existing issues ### Package Version ^0.1.7 ### Current Behavior > Type 'TopicFilter' is not assignable to type '[signature: `0x${string}`, ...args: LogTopic[]]'. Source provides no ...
Related [discussion](https://github.com/wagmi-dev/viem/discussions/163) and [PR](https://github.com/wagmi-dev/viem/pull/178). It may not make sense for `decodeEventLog` to require the first element of the `topics` array to be a `Hex`, because anonymous events with no indexed parameters have `topics == []`. Relate...
Related [discussion](https://github.com/wagmi-dev/viem/discussions/163) and [PR](https://github.com/wagmi-dev/viem/pull/178). It may not make sense for `decodeEventLog` to require the first element of the `topics` array to be a `Hex`, because anonymous events with no indexed parameters have `topics == []`. Relate...
[ "https://github.com/wevm/viem/commit/36bb33f01cbdc467fd2f871a2527db282a4e9e48", "https://github.com/wevm/viem/commit/1b7a815658e2e9cb21cd03c8a131c0deab5caf20", "https://github.com/wevm/viem/commit/07071cd7b3e88d61e25da73605fdf46b4f026488" ]
2023-03-12T19:25:19
1.0
TypeScript
honojs/hono
4,423
honojs__hono-4423
[ 4196 ]
393ded96196da1b4f23813fea670b0d5a70526c6
diff --git a/src/helper/route/index.ts b/src/helper/route/index.ts index bffebe28f..1587f630e 100644 --- a/src/helper/route/index.ts +++ b/src/helper/route/index.ts @@ -37,23 +37,32 @@ export const matchedRoutes = (c: Context): RouterRoute[] => * Get the route path registered within the handler * * @param {Contex...
diff --git a/src/helper/route/index.test.ts b/src/helper/route/index.test.ts index 52e6f50d6..18106a784 100644 --- a/src/helper/route/index.test.ts +++ b/src/helper/route/index.test.ts @@ -63,6 +63,11 @@ describe('routePath', () => { expect(routePath(c)).toBe('/:id') + expect(routePath(c, 0)).toBe('/:id') +...
Support get real route path in middleware ### What is the feature you are proposing? Now ```ts app.use(async (c, next) => { console.log(c.req.method, c.req.routePath, c.req.path, c.req.url) // GET /* /user/1 http://127.0.0.1:3000/user/1 } app.get("/user/:id", ...) // an...
Hi @seepine Now, you can use Route helper: https://hono.dev/docs/helpers/route ```ts import { Hono } from 'hono' import { routePath } from 'hono/route' const app = new Hono() app.get('/user/:id', (c) => { console.log(routePath(c)) // `/user/:id` return c.json({}) }) export default app ``` @yusukebe Hi, i want...
Hi @seepine Now, you can use Route helper: https://hono.dev/docs/helpers/route ```ts import { Hono } from 'hono' import { routePath } from 'hono/route' const app = new Hono() app.get('/user/:id', (c) => { console.log(routePath(c)) // `/user/:id` return c.json({}) }) export default app ``` @yusukebe Hi, i want...
[ "https://github.com/honojs/hono/commit/34bb026c0916d8bf0e64c803da2ac56dfb6a8e42" ]
2025-09-23T01:06:40
1.6
TypeScript
honojs/hono
1,715
honojs__hono-1715
[ 1713 ]
1ed742bdb80518437e6d6f9c6ec7a5fbe300f254
diff --git a/deno_dist/hono-base.ts b/deno_dist/hono-base.ts index 6a356d960..5cfc267c0 100644 --- a/deno_dist/hono-base.ts +++ b/deno_dist/hono-base.ts @@ -279,7 +279,7 @@ class Hono< const path = this.getPath(request, { env }) const [handlers, paramStash] = this.matchRoute(method, path) - const c = new...
diff --git a/src/hono.test.ts b/src/hono.test.ts index 29b15cc71..8fe95d2f1 100644 --- a/src/hono.test.ts +++ b/src/hono.test.ts @@ -659,6 +659,12 @@ describe('param and query', () => { expect(await res.text()).toBe('id is 123') }) + it('param of /entry/:id is found, even for Array object method names'...
Param value of "keys" resolves to a function, not the value "keys" ### What version of Hono are you using? 3.10.1 ### What runtime/platform is your app running on? Node, Cloudflare Workers ### What steps can reproduce the bug? Create a Hono app with multiple nested routes: ```ts // Adapted from Hono'...
I have [a fork](https://github.com/AverageHelper/hono/tree/avg/param-keys) where I've already added a failing test as described. The issue seems primarily to occur in src/request.ts:56: https://github.com/honojs/hono/blob/1ed742bdb80518437e6d6f9c6ec7a5fbe300f254/src/request.ts#L56 In the failing case, `this._s` i...
I have [a fork](https://github.com/AverageHelper/hono/tree/avg/param-keys) where I've already added a failing test as described. The issue seems primarily to occur in src/request.ts:56: https://github.com/honojs/hono/blob/1ed742bdb80518437e6d6f9c6ec7a5fbe300f254/src/request.ts#L56 In the failing case, `this._s` i...
[ "https://github.com/honojs/hono/commit/f9146dedfcba64114dbba5522a1b0688781379d4", "https://github.com/honojs/hono/commit/cdb95ea3c30aa1516aef922a658c5cc9fb34f71a", "https://github.com/honojs/hono/commit/02ec456b0c957aabd1bfc0674839cc3daac34a4b", "https://github.com/honojs/hono/commit/38169ea43d278a57aa4bdb0a8...
2023-11-16T21:29:28
1.6
TypeScript
honojs/hono
2,122
honojs__hono-2122
[ 2100 ]
60e85b31cf1024e27a2d6421041d279e0f3db305
diff --git a/deno_dist/types.ts b/deno_dist/types.ts index 03c64f892..3c7c4b1a1 100644 --- a/deno_dist/types.ts +++ b/deno_dist/types.ts @@ -3,7 +3,7 @@ /* eslint-disable @typescript-eslint/ban-types */ import type { Context } from './context.ts' import type { Hono } from './hono.ts' -import type { IntersectNonAnyTy...
diff --git a/src/types.test.ts b/src/types.test.ts index ea9247b48..a6a81412a 100644 --- a/src/types.test.ts +++ b/src/types.test.ts @@ -525,7 +525,6 @@ describe('merge path', () => { message: string } } - } & { $get: { input: {} output: { @@ -557,6 +...
Path params are not inferred correctly ### What version of Hono are you using? 3.12.7 ### What runtime/platform is your app running on? Bun ### What steps can reproduce the bug? ```ts import { Hono } from 'hono'; import { hc } from 'hono/client'; const app1 = new Hono().get('/c/:d', async (c) => c.json({ mess...
Hi @siriscmv Thanks for raising the issue. This is a bug. I'll fix it later.
Hi @siriscmv Thanks for raising the issue. This is a bug. I'll fix it later.
[ "https://github.com/honojs/hono/commit/b27868c54ee6eef71ff75cdc1eaa31dcb490f6e5", "https://github.com/honojs/hono/commit/a86f1231b6a3ff0294e1192246b50683a141b58a", "https://github.com/honojs/hono/commit/7e81ea1713790967e919154c801da3dbc4a92c19", "https://github.com/honojs/hono/commit/31eded145682d316a02aa5527...
2024-01-30T23:13:47
1.6
TypeScript
honojs/hono
1,769
honojs__hono-1769
[ 1766 ]
bd00d284693e2079bb3be7ee762bcde53b194c73
diff --git a/deno_dist/client/types.ts b/deno_dist/client/types.ts index afc517a9e..24128dc6f 100644 --- a/deno_dist/client/types.ts +++ b/deno_dist/client/types.ts @@ -26,11 +26,7 @@ type ClientRequest<S extends Schema> = { $url: () => URL } -type BlankRecordToNever<T> = T extends Record<infer R, unknown> - ? R...
diff --git a/src/client/client.test.ts b/src/client/client.test.ts index e06b20a00..f02d3b0f9 100644 --- a/src/client/client.test.ts +++ b/src/client/client.test.ts @@ -5,7 +5,7 @@ import FormData from 'form-data' import { rest } from 'msw' import { setupServer } from 'msw/node' import _fetch, { Request as NodeFetch...
ClientResponse.json() with possibly undefined values is always inferred as "never" ### What version of Hono are you using? 3.10.1 ### What runtime/platform is your app running on? Node / Browser ### What steps can reproduce the bug? When ClientResponse.json() is called with a type that has an optional fi...
[ "https://github.com/honojs/hono/commit/4ca51ed1c7c5700d6861ee03acd0794015127c75", "https://github.com/honojs/hono/commit/41867a085af38005e0e5bdb63f1fd69bcba8d8f4" ]
2023-12-03T09:39:21
1.6
TypeScript
honojs/hono
4,249
honojs__hono-4249
[ 2175, 3088 ]
5149aa421bef92d3a495287f2f67bca4382bad39
diff --git a/src/helper/ssg/middleware.ts b/src/helper/ssg/middleware.ts index 0e4a4909c..e9684cb8d 100644 --- a/src/helper/ssg/middleware.ts +++ b/src/helper/ssg/middleware.ts @@ -1,5 +1,6 @@ import type { Context } from '../../context' import type { Env, MiddlewareHandler } from '../../types' +import { isDynamicRou...
diff --git a/src/helper/ssg/ssg.test.tsx b/src/helper/ssg/ssg.test.tsx index 9af23e3df..67af8b863 100644 --- a/src/helper/ssg/ssg.test.tsx +++ b/src/helper/ssg/ssg.test.tsx @@ -955,3 +955,42 @@ describe('SSG Plugin System', () => { ) }) }) + +describe('ssgParams', () => { + it('should invoke callback only onc...
Invoke callback for `ssgParams()` only once ### What is the feature you are proposing? Same issue as @nakasyou mentions below, but now `ssgParams()` is pure middleware and also not handling special skipping internally, so it is called many times during SSG. https://github.com/honojs/hono/pull/2169#issuecomment-1934...
How about that? @yusukebe @sor4chi @watany-dev @nakasyou @usualoma Hi! Interesting approach. I'll take a look at the details later. But can you think of any other PSEUDO middleware? @yusukebe Hmmm no, there is no particular other use for PSEUDO middleware. But I still don't think "send a request to the entire ro...
How about that? @yusukebe @sor4chi @watany-dev @nakasyou @usualoma Hi! Interesting approach. I'll take a look at the details later. But can you think of any other PSEUDO middleware? @yusukebe Hmmm no, there is no particular other use for PSEUDO middleware. But I still don't think "send a request to the entire ro...
[ "https://github.com/honojs/hono/commit/bf8909eb3bee65320364a8906dbf6b000268a2e5", "https://github.com/honojs/hono/commit/2d4579d5b8985a53a3bd2c5a82b03ebd00230f5b" ]
2025-06-27T02:38:23
1.6
TypeScript
denoland/std
3,310
denoland__std-3310
[ 3223 ]
c05ce92bf23cbfde1eb74111645a40a4326758a1
diff --git a/encoding/ascii85.ts b/encoding/ascii85.ts index 5487ee072625..45f680e6e787 100644 --- a/encoding/ascii85.ts +++ b/encoding/ascii85.ts @@ -76,7 +76,7 @@ export function encode(uint8: Uint8Array, options?: Ascii85Options): string { uint8 = new Uint8Array(tmp.length + difference); uint8.set(tmp); ...
diff --git a/encoding/ascii85_test.ts b/encoding/ascii85_test.ts index 84255a3280c9..3af1b24a6c37 100644 --- a/encoding/ascii85_test.ts +++ b/encoding/ascii85_test.ts @@ -176,3 +176,19 @@ for (const [standard, tests] of Object.entries(testCasesDelimiter)) { }, }); } + +Deno.test({ + name: `[encoding/ascii85] ...
encoding/ascii85.ts: `encode()` returns a wrong result with a 4-byte subarray #### Describe the bug The `encode()` function from *encoding/ascii.ts* returns a wrong result with a subarray. More specifically, if a subarray is a 4-byte (or multiples of 4 bytes) slice of a buffer longer than it, and the slice refers ...
Probably the same issue that I've fixed here - https://github.com/denoland/deno_std/pull/3208 https://github.com/denoland/deno_std/blob/69fa1e956c2469f168756d757b1653323327ed53/encoding/ascii85.ts#L78-L79 Should be trivial to port the patch there with the appropriate test.
Probably the same issue that I've fixed here - https://github.com/denoland/deno_std/pull/3208 https://github.com/denoland/deno_std/blob/69fa1e956c2469f168756d757b1653323327ed53/encoding/ascii85.ts#L78-L79 Should be trivial to port the patch there with the appropriate test.
[ "https://github.com/denoland/std/commit/88d74458c02314ea32a285c03fc37dc7cbb55e98", "https://github.com/denoland/std/commit/9055eda9b1e9726df86d48fa51b9f5a360e4bf6e", "https://github.com/denoland/std/commit/cc0bae1749a3bf117c5e816c74235ddcd4d88ec6" ]
2023-04-09T15:39:41
0.138
TypeScript
denoland/std
6,378
denoland__std-6378
[ 6374 ]
b7c76d5d904dcdd307296d5ee5f5dd9a22771523
diff --git a/cli/deno.json b/cli/deno.json index aaab86bc67f4..f0a23aea24f5 100644 --- a/cli/deno.json +++ b/cli/deno.json @@ -5,6 +5,8 @@ ".": "./mod.ts", "./parse-args": "./parse_args.ts", "./prompt-secret": "./prompt_secret.ts", + "./unstable-progress-bar": "./unstable_progress_bar.ts", + "./uns...
diff --git a/cli/unstable_progress_bar_stream_test.ts b/cli/unstable_progress_bar_stream_test.ts new file mode 100644 index 000000000000..30be83b146d2 --- /dev/null +++ b/cli/unstable_progress_bar_stream_test.ts @@ -0,0 +1,42 @@ +// Copyright 2018-2025 the Deno authors. MIT license. + +import { assertEquals } from "@st...
feat: `@std/cli` should have a progress bar function The `@std/cli` has a spinner function to display the fact that something is loading, likewise we should also have a progress bar function that enables us to show the progress of something happening.
I am in favour of adding this to std. What should it look like by default and what should be customizable? There are many different cli progress bar styles in cli land, some with, some without percentage and/or n/m displays, prefixes, suffixes etc. `[####----------------]`, `[####----------------] 20%`, `[####---------...
I am in favour of adding this to std. What should it look like by default and what should be customizable? There are many different cli progress bar styles in cli land, some with, some without percentage and/or n/m displays, prefixes, suffixes etc. `[####----------------]`, `[####----------------] 20%`, `[####---------...
[ "https://github.com/denoland/std/commit/2cf63a4a8dc3fe9a0d0a72a2d450a3621c47f690", "https://github.com/denoland/std/commit/f77522d877bec016d7432a41025f577ebd4bac47", "https://github.com/denoland/std/commit/24da78cc0776d0d615814be8dc115b6466627227", "https://github.com/denoland/std/commit/252ff3ee1ef79b785f43e...
2025-02-03T10:29:53
0.138
TypeScript
denoland/std
5,173
denoland__std-5173
[ 5177 ]
b11514e21d120f736650a728e76fd7cf6cac6377
diff --git a/json/deno.json b/json/deno.json index 1738a5985775..6e48c342d71d 100644 --- a/json/deno.json +++ b/json/deno.json @@ -5,7 +5,7 @@ ".": "./mod.ts", "./types": "./types.ts", "./concatenated-json-parse-stream": "./concatenated_json_parse_stream.ts", - "./json-parse-stream": "./json_parse_str...
diff --git a/json/_test_utils.ts b/json/_test_utils.ts index 1ee765f73359..75c0870aa45c 100644 --- a/json/_test_utils.ts +++ b/json/_test_utils.ts @@ -1,7 +1,7 @@ // Copyright 2018-2024 the Deno authors. All rights reserved. MIT license. import { assertEquals, assertRejects } from "@std/assert"; import type { Concat...
proposal(json,csv): avoid repetition in entrypoint name if it has the same word as the pacakge name in the beginning In addition to #5162, the core team suggests the below entrypoint name changes to make the rule more consistent across std. - `std/csv/csv-parse-stream` -> `std/csv/parse-stream` - `std/csv/csv-strin...
Should we also do the rename of `@std/json/concatenated-json-parse-stream` -> `@std/json/concatenated-parse-stream`? context: https://github.com/denoland/deno_std/pull/5173#discussion_r1658192661
[ "https://github.com/denoland/std/commit/438bf9a4e6150de5947471db3734f0b1d5e99575", "https://github.com/denoland/std/commit/e2aca0d061f948e8309c2c79019b16a3a0b42771", "https://github.com/denoland/std/commit/19b6056a5f4eb920256e6c11d223fc5e465d6cbd", "https://github.com/denoland/std/commit/ac3faccd9b3ac4b27709e...
2024-06-27T07:58:10
0.138
TypeScript
denoland/std
3,254
denoland__std-3254
[ 3094 ]
3e98ac2b302ad0abfe683253bb97a36651439b27
diff --git a/front_matter/mod.ts b/front_matter/mod.ts index a634a4ff9f87..9a4ab94ca2d2 100644 --- a/front_matter/mod.ts +++ b/front_matter/mod.ts @@ -129,6 +129,13 @@ * = toml = * ``` * + * ```markdown + * +++ + * is = 'that' + * not = 'cool?' + * +++ + * ``` + * * #### JSON * * ```markdown @@ -175,6 +182,...
diff --git a/front_matter/_test_utils.ts b/front_matter/_test_utils.ts index a498a43a3b19..ee3639ad5ba0 100644 --- a/front_matter/_test_utils.ts +++ b/front_matter/_test_utils.ts @@ -194,3 +194,31 @@ tags = ['toml', 'front-matter'] "with some ---toml 👌 crazy stuff in it", ); } + +export async function runExtr...
TOML frontmatter extraction should look between +++ instead of --- **Describe the bug** **Steps to Reproduce** extract TOML frontmatter from a hugo/zola blog post: ``` +++ title = "Title" +++ Content ``` using https://deno.land/std@0.171.0/encoding/front_matter/toml.ts doen't extract the frontmatter at...
Is this convention common across tools? Or specific to Hugo? It's definitely not in the spec (ref: https://github.com/toml-lang/toml/issues/511). I think that this is application-specific, but I honestly don't see a lot of tools that use toml front matter in general. I would be okay with changing it just because of Hug...
Is this convention common across tools? Or specific to Hugo? It's definitely not in the spec (ref: https://github.com/toml-lang/toml/issues/511). I think that this is application-specific, but I honestly don't see a lot of tools that use toml front matter in general. I would be okay with changing it just because of Hug...
[ "https://github.com/denoland/std/commit/7c7f217c33f3e5057c40cd6a32211b7620ddad1d", "https://github.com/denoland/std/commit/72da38088a926bd7677c37ebaa5e65b5749578b0", "https://github.com/denoland/std/commit/47a62fcd095debb9466a6dfcae632b92d8077e9d" ]
2023-03-14T15:39:12
0.138
TypeScript
denoland/std
6,246
denoland__std-6246
[ 4955 ]
b2b7f9968305dd8436350da16d4236751cca74c1
diff --git a/assert/not_equals.ts b/assert/not_equals.ts index 10da792b814d..b87fd7dd0beb 100644 --- a/assert/not_equals.ts +++ b/assert/not_equals.ts @@ -3,6 +3,7 @@ import { equal } from "./equal.ts"; import { AssertionError } from "./assertion_error.ts"; +import { format } from "@std/internal/format"; /** *...
diff --git a/assert/not_equals_test.ts b/assert/not_equals_test.ts index c9e86bb1de1f..273748cf7791 100644 --- a/assert/not_equals_test.ts +++ b/assert/not_equals_test.ts @@ -17,7 +17,18 @@ Deno.test("assertNotEquals() throws", () => { assertNotEquals("foo", "foo"); }, AssertionError, - "Expected ac...
assertNotEquals assertion error message discrepancy There is an issue with the `assertNotEquals` output int the current version of the library. The assertion error message does not reflect the expected string values accurately. Specifically, the following test case: `assertNotEquals('1','1');` is expected to thro...
I'm happy to add quotes to strings for this function. WDYT, @kt3k? The suggestion makes sense to me. Maybe we should use `format` of `std/internal` to make the expression?
I'm happy to add quotes to strings for this function. WDYT, @kt3k? The suggestion makes sense to me. Maybe we should use `format` of `std/internal` to make the expression?
[ "https://github.com/denoland/std/commit/fe8a641792ed9edc2466ef3f8609e9893efce7c8", "https://github.com/denoland/std/commit/acb1c1f6e5b9acf913801dda874a6a1abe341e79" ]
2024-12-09T08:55:11
0.138
TypeScript
adobe/spectrum-web-components
3,392
adobe__spectrum-web-components-3392
[ 3238 ]
98d03701b05101bae4a9e1f4d554bf0648979884
diff --git a/.circleci/config.yml b/.circleci/config.yml index 49b26d9dd4f..79856383a90 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -10,7 +10,7 @@ executors: parameters: current_golden_images_hash: type: string - default: 31192df5022fe2dfc067ca7b4c8d72b0d2d98510 + defaul...
diff --git a/packages/picker/test/index.ts b/packages/picker/test/index.ts index 55aa24004c8..1b689db5743 100644 --- a/packages/picker/test/index.ts +++ b/packages/picker/test/index.ts @@ -39,11 +39,19 @@ import { findAccessibilityNode, sendKeys, } from '@web/test-runner-commands'; -import { iconsOnly } from...
[Bug][a11y]: Picker: VoiceOver fails to announce label in Chrome ### Code of conduct - [X] I agree to follow this project's code of conduct. ### Impacted component(s) Picker ### Expected behavior The button element in the sp-picker component's shadow DOM is labeled internally using aria-labelledby: 1. ...
[ "https://github.com/adobe/spectrum-web-components/commit/218bf84a5fa36c18d37a1c53605fc481838ebf8a", "https://github.com/adobe/spectrum-web-components/commit/8fef06a67eb1ac667920ec8db868ca941b550779" ]
2023-06-29T12:15:14
0.0
TypeScript
adobe/spectrum-web-components
4,494
adobe__spectrum-web-components-4494
[ 4225 ]
e1ef097bc4c4a1e888de028f40b6f2bb5ea2d7b8
diff --git a/packages/progress-bar/src/ProgressBar.ts b/packages/progress-bar/src/ProgressBar.ts index b9799764ff3..5eebbebf5ff 100644 --- a/packages/progress-bar/src/ProgressBar.ts +++ b/packages/progress-bar/src/ProgressBar.ts @@ -72,9 +72,8 @@ export class ProgressBar extends SizedMixin( ? html` ...
diff --git a/packages/progress-bar/test/progress-bar.test.ts b/packages/progress-bar/test/progress-bar.test.ts index e7bb6755f28..9d7ee40be79 100644 --- a/packages/progress-bar/test/progress-bar.test.ts +++ b/packages/progress-bar/test/progress-bar.test.ts @@ -21,18 +21,14 @@ import { createLanguageContext } from '../....
[Bug]: duplicate label in sp-progress-bar ### Code of conduct - [X] I agree to follow this project's code of conduct. ### Impacted component(s) sp-progress-bar, sp-field-label ### Expected behavior An sp-progress-bar that is initially created with an undefined label, and later has a label defined, should display t...
[ "https://github.com/adobe/spectrum-web-components/commit/c48598f8d920ee1d883f8ac2710148eeb426ba19", "https://github.com/adobe/spectrum-web-components/commit/3257a18819124584d60bf2cbe111bb89efb04bbb", "https://github.com/adobe/spectrum-web-components/commit/fb42db12d3b6ffae8a48534c2f0642fca86dc4ec", "https://g...
2024-05-23T17:25:50
0.0
TypeScript
adobe/spectrum-web-components
4,263
adobe__spectrum-web-components-4263
[ 4201 ]
8b61b0aec9ee6ffd363809957b45a4a56650acd6
diff --git a/packages/number-field/src/NumberField.ts b/packages/number-field/src/NumberField.ts index a85afc41a2a..0c80f504704 100644 --- a/packages/number-field/src/NumberField.ts +++ b/packages/number-field/src/NumberField.ts @@ -495,7 +495,9 @@ export class NumberField extends TextfieldBase { // Step shoul...
diff --git a/packages/number-field/test/inputs.test.ts b/packages/number-field/test/inputs.test.ts index 940d7779433..d23f0dd2e2d 100644 --- a/packages/number-field/test/inputs.test.ts +++ b/packages/number-field/test/inputs.test.ts @@ -314,6 +314,27 @@ describe('NumberField - inputs', () => { expect(el.va...
[Bug]: Editable Slider not rounding values ### Code of conduct - [X] I agree to follow this project's code of conduct. ### Impacted component(s) Slider ### Expected behavior Editable Slider onChange `event.target.value` should print 0.56 after adding`0.55999999999` on the NumberField ### Actual beha...
Would this be considered a duplicate of #3817?
Would this be considered a duplicate of #3817?
[ "https://github.com/adobe/spectrum-web-components/commit/3f6fde40728d06763081714407fdde11b0647f56", "https://github.com/adobe/spectrum-web-components/commit/c8a49bc648fa4fac2ceba415bedcb0e33b77ff9e", "https://github.com/adobe/spectrum-web-components/commit/15bf1417c0f115b841fdca19422d7a7b2ec1e6a5", "https://g...
2024-04-12T05:39:00
0.0
TypeScript
adobe/spectrum-web-components
4,155
adobe__spectrum-web-components-4155
[ 3811 ]
9c9bf952cf2a1e4a0c5bc35e63e46f5d5bd6afe8
diff --git a/packages/split-view/src/SplitView.ts b/packages/split-view/src/SplitView.ts index 04776578aed..c39805e557b 100644 --- a/packages/split-view/src/SplitView.ts +++ b/packages/split-view/src/SplitView.ts @@ -184,8 +184,9 @@ export class SplitView extends SpectrumElement { this.viewSize...
diff --git a/packages/split-view/test/split-view.test.ts b/packages/split-view/test/split-view.test.ts index 8d36c4e2485..811f35f7524 100644 --- a/packages/split-view/test/split-view.test.ts +++ b/packages/split-view/test/split-view.test.ts @@ -972,6 +972,41 @@ describe('SplitView', () => { expect(testPanel).t...
[split-view]: update label attribute to be customisable ### Code of conduct - [X] I agree to follow this project's code of conduct. ### Description of issue Follow up to the work done in https://github.com/adobe/spectrum-web-components/pull/3800 The `this.label` attribute in `sp-split-view` is inconsistent with ...
[ "https://github.com/adobe/spectrum-web-components/commit/e3317ccffdd2e9abfd727ddaba2a5dfa05d63a59" ]
2024-03-07T22:15:54
0.0
TypeScript
adobe/spectrum-web-components
4,933
adobe__spectrum-web-components-4933
[ 3272 ]
bb53e32ef16d239c3310b9a75c94eab06687ab21
diff --git a/packages/number-field/src/NumberField.ts b/packages/number-field/src/NumberField.ts index 447771ca3db..90d67581bad 100644 --- a/packages/number-field/src/NumberField.ts +++ b/packages/number-field/src/NumberField.ts @@ -747,7 +747,7 @@ export class NumberField extends TextfieldBase { ...
diff --git a/packages/number-field/test/number-field.test.ts b/packages/number-field/test/number-field.test.ts index 1521027c9d0..333bca287f0 100644 --- a/packages/number-field/test/number-field.test.ts +++ b/packages/number-field/test/number-field.test.ts @@ -1753,7 +1753,7 @@ describe('NumberField', () => { ...
[Bug]: sp-number-field pressing increment/decrement buttons using NVDA moves focus to the text field ### Code of conduct - [X] I agree to follow this project's code of conduct. ### Impacted component(s) sp-number-field ### Expected behavior When I press the increment or decrement buttons focus should stay on the b...
Related to #3274 #3271
Related to #3274 #3271
[ "https://github.com/adobe/spectrum-web-components/commit/e1515b8ece537a658b3e0e55da9b0042b20d2525", "https://github.com/adobe/spectrum-web-components/commit/e767930254e02a544953a396d292502f09f9ae66", "https://github.com/adobe/spectrum-web-components/commit/740b3ed6ba2dbf958717f8f996e67546ffa02a6b", "https://g...
2024-11-12T17:40:15
0.0
TypeScript
wxt-dev/wxt
294
wxt-dev__wxt-294
[ 293 ]
7fd5752ef13e87f889fc3db4868fcaabda26cfba
diff --git a/demo/package.json b/demo/package.json index 7ba78c265..3e3685345 100644 --- a/demo/package.json +++ b/demo/package.json @@ -19,13 +19,11 @@ "dependencies": { "react": "^18.2.0", "react-dom": "^18.2.0", - "vitest": "^0.34.6", - "webextension-polyfill": "^0.10.0" + "vitest": "^1.1.0" ...
diff --git a/demo/src/entrypoints/__tests__/background.test.ts b/demo/src/entrypoints/__tests__/background.test.ts index 455122e71..42bf30a72 100644 --- a/demo/src/entrypoints/__tests__/background.test.ts +++ b/demo/src/entrypoints/__tests__/background.test.ts @@ -1,4 +1,4 @@ -import { describe, expect, it, vi } from '...
`wxt/testing` doesn't mock `webextension-polyfill` correctly ### Describe the bug The polyfill gets loaded into the tests, throwing an error: ``` $ pnpm test run > demo@1.0.0 test /Users/aklinker1/Downloads/demo > vitest "run" RUN v1.1.0 /Users/aklinker1/Downloads/demo ❯ entrypoints/__tests__/bac...
Still not sure why the current solution is working in the `wxt` monorepo and not in real projects... But I have a solution. For some background: To mock `webextension-polyfill`, Vite needs to process the JS file that imports it. To process the JS file, it needs to be marked as "inline" (or non-external). The current...
Still not sure why the current solution is working in the `wxt` monorepo and not in real projects... But I have a solution. For some background: To mock `webextension-polyfill`, Vite needs to process the JS file that imports it. To process the JS file, it needs to be marked as "inline" (or non-external). The current...
[ "https://github.com/wxt-dev/wxt/commit/b5614eabc9e10176da1df62a78844c5d17e00649", "https://github.com/wxt-dev/wxt/commit/a5ed4539b57b99104e20e7f078547272d9b83346", "https://github.com/wxt-dev/wxt/commit/b06dbc4baceecdccab35044cc4de76babf718ad4" ]
2023-12-22T22:09:35
0.7
TypeScript
wxt-dev/wxt
1,074
wxt-dev__wxt-1074
[ 1069 ]
1b900e942b648c3adaa960edd9f5a63b47b42f4f
diff --git a/packages/wxt/src/core/resolve-config.ts b/packages/wxt/src/core/resolve-config.ts index 8269179ca..5c2b9cd9d 100644 --- a/packages/wxt/src/core/resolve-config.ts +++ b/packages/wxt/src/core/resolve-config.ts @@ -96,7 +96,21 @@ export async function resolveConfig( const publicDir = path.resolve(srcDir, m...
diff --git a/packages/wxt/e2e/tests/user-config.test.ts b/packages/wxt/e2e/tests/user-config.test.ts index 01ac7f4d1..c0b497508 100644 --- a/packages/wxt/e2e/tests/user-config.test.ts +++ b/packages/wxt/e2e/tests/user-config.test.ts @@ -130,4 +130,31 @@ describe('User Config', () => { await project.fileExists('....
`outDirTemplate` for customizing output directory ### Feature Request Add a new config, `outDirTemplate`, that defaults to `{{browser}}-mv{{manifestVersion}}`. Template variables are: | Template Var | Value | | --- | --- | | `{{browser}}` | `wxt.config.browser` | `{{manifestVersion}}` | `wxt.config.manifestVer...
Released in [`v0.19.12`](https://github.com/wxt-dev/wxt/releases/tag/wxt-v0.19.12)
[ "https://github.com/wxt-dev/wxt/commit/5325089e2a71e43f710c4eb896daff68c7f04f09", "https://github.com/wxt-dev/wxt/commit/b5348609fe4f26315bf9423a26d5bfad14fc4f12", "https://github.com/wxt-dev/wxt/commit/0ea504dba7c8fafb5aac4d45095d6ad733dc0904", "https://github.com/wxt-dev/wxt/commit/1044dc069fda93dab465a5310...
2024-10-17T14:26:43
0.2
TypeScript
wxt-dev/wxt
1,590
wxt-dev__wxt-1590
[ 1580 ]
7c59e9d5b5f79819a5a2f1983153cc6a96854ca0
diff --git a/packages/wxt/src/core/builders/vite/index.ts b/packages/wxt/src/core/builders/vite/index.ts index 8eb2068ab..c798749da 100644 --- a/packages/wxt/src/core/builders/vite/index.ts +++ b/packages/wxt/src/core/builders/vite/index.ts @@ -308,7 +308,10 @@ export async function createViteBuilder( async build(...
diff --git a/packages/wxt/e2e/tests/output-structure.test.ts b/packages/wxt/e2e/tests/output-structure.test.ts index 4fd96d354..2c08556ff 100644 --- a/packages/wxt/e2e/tests/output-structure.test.ts +++ b/packages/wxt/e2e/tests/output-structure.test.ts @@ -220,6 +220,77 @@ describe('Output Directory Structure', () => {...
Unlisted CSS using preprocessor does not build css file ### Describe the bug I encountered a situation where I needed to add a stylesheet dynamically, so I tried using unlisted CSS. I created a .scss as unlisted CSS, but the scss file was not generated as a CSS output. When adding regular .css as unlisted CSS, it wor...
I have submitted a PR to fix this issue. #1590 After further investigation, I found that the same issue not only with Sass but with all CSS preprocessors, so I have updated the title
I have submitted a PR to fix this issue. #1590 After further investigation, I found that the same issue not only with Sass but with all CSS preprocessors, so I have updated the title
[ "https://github.com/wxt-dev/wxt/commit/cef5945882899513f52e08990f25dbae1f9e787f", "https://github.com/wxt-dev/wxt/commit/4dbaec22a4c4dff45be86aa2f4316cbde7a35702", "https://github.com/wxt-dev/wxt/commit/9ddeb25ecf05cda81b990a9ea3588bb2d4919f7f" ]
2025-04-18T09:45:44
0.5
TypeScript
wxt-dev/wxt
1,407
wxt-dev__wxt-1407
[ 1403 ]
868a347d40c54bcc78f20f099a1a0cd8a7175cc5
diff --git a/docs/guide/essentials/config/typescript.md b/docs/guide/essentials/config/typescript.md index be2208832..8d939e2e0 100644 --- a/docs/guide/essentials/config/typescript.md +++ b/docs/guide/essentials/config/typescript.md @@ -14,7 +14,7 @@ At a minimum, you need to create a TSConfig in your root directory th...
diff --git a/packages/wxt/e2e/tests/auto-imports.test.ts b/packages/wxt/e2e/tests/auto-imports.test.ts index f8b58e4e6..144b972e8 100644 --- a/packages/wxt/e2e/tests/auto-imports.test.ts +++ b/packages/wxt/e2e/tests/auto-imports.test.ts @@ -52,10 +52,10 @@ describe('Auto Imports', () => { -------------------...
Incorrect use of triple-slash directives ### Describe the bug Both in code (e.g. [here](https://github.com/wxt-dev/wxt/blob/48a87aa352edbd0d095864fe1c14b50682f78dee/packages/wxt/src/core/generate-wxt-dir.ts#L220)) and documentation (e.g. [here](https://github.com/wxt-dev/wxt/blob/48a87aa352edbd0d095864fe1c14b50682f78d...
Good find, thanks for the info. I can get to this next week, or if you're willing, I'd accept a PR! You've already linked to all the relevant code, I don't think there's any other relevant lines that need changed.
Good find, thanks for the info. I can get to this next week, or if you're willing, I'd accept a PR! You've already linked to all the relevant code, I don't think there's any other relevant lines that need changed. Fix released in [v0.19.27](https://github.com/wxt-dev/wxt/releases/tag/wxt-v0.19.27)
[ "https://github.com/wxt-dev/wxt/commit/b96fa08c294b504ad2905fe9f26ef34ed8119863", "https://github.com/wxt-dev/wxt/commit/c323d334409fea80ca681e562dffb17270ccc426" ]
2025-02-07T16:53:10
2.0
TypeScript
wxt-dev/wxt
865
wxt-dev__wxt-865
[ 864 ]
9eb64d94d6ad53429b3bfcb080eb9e90dcb02b8a
diff --git a/packages/wxt/package.json b/packages/wxt/package.json index 89ba57ae8..271d3db01 100644 --- a/packages/wxt/package.json +++ b/packages/wxt/package.json @@ -1,7 +1,7 @@ { "name": "wxt", "type": "module", - "version": "0.19.0", + "version": "0.19.1-alpha2", "description": "Next gen framework for ...
diff --git a/packages/wxt/e2e/tests/remote-code.test.ts b/packages/wxt/e2e/tests/remote-code.test.ts index 481a9e9c9..f4ac9f935 100644 --- a/packages/wxt/e2e/tests/remote-code.test.ts +++ b/packages/wxt/e2e/tests/remote-code.test.ts @@ -3,7 +3,7 @@ import { TestProject } from '../utils'; describe('Remote Code', () =...
window not defined in content shared file in v0.19 ### Describe the bug I have a content script which has a react code. I have created constant file from which i export window variable. the `wxt prepare` command fails <details> <summary>Error logs</summary> ``` > wxt prepare WXT 0.19.0 ...
I have the same issue, the side effect of the import statement is triggered in v0.19.0, but not in v.0.18.0. Pinged @aklinker1 about this in the Discord but seems to be an issue from the move to tsup, same behaviour with `self` @aiktb @Timeraa @mehimanshupatil Can you guys try out `wxt@0.19.1-alpha1` and let me know if...
I have the same issue, the side effect of the import statement is triggered in v0.19.0, but not in v.0.18.0. Pinged @aklinker1 about this in the Discord but seems to be an issue from the move to tsup, same behaviour with `self` @aiktb @Timeraa @mehimanshupatil Can you guys try out `wxt@0.19.1-alpha1` and let me know if...
[ "https://github.com/wxt-dev/wxt/commit/4b7f43d5588899cb4fd956342dbacd00af270e41", "https://github.com/wxt-dev/wxt/commit/1d60e2eba0367b5559c87f3327b11d3b564b2a16", "https://github.com/wxt-dev/wxt/commit/f449c2b80b67f78ec652e9951f8785c0cdffd968", "https://github.com/wxt-dev/wxt/commit/17059c3a4322add23027f0321...
2024-07-26T20:04:56
1.0
TypeScript
google-gemini/gemini-cli
7,408
google-gemini__gemini-cli-7408
[ 7043 ]
4c38227256e3618a6eafe023684082d0538cc7b0
diff --git a/packages/vscode-ide-companion/src/extension.ts b/packages/vscode-ide-companion/src/extension.ts index 36fc4029d10..66020cb94f3 100644 --- a/packages/vscode-ide-companion/src/extension.ts +++ b/packages/vscode-ide-companion/src/extension.ts @@ -6,9 +6,11 @@ import * as vscode from 'vscode'; import { IDE...
diff --git a/packages/vscode-ide-companion/src/extension.test.ts b/packages/vscode-ide-companion/src/extension.test.ts index 2223050bcfa..8377c01e97d 100644 --- a/packages/vscode-ide-companion/src/extension.test.ts +++ b/packages/vscode-ide-companion/src/extension.test.ts @@ -50,12 +50,18 @@ vi.mock('vscode', () => ({ ...
Notify users when a new version of the Gemini CLI Companion extension is available ### What would you like to be added? A notification that alerts users when a new version of the Gemini CLI Companion extension is available and provides a clear call to action to update. This notification should include: - A message th...
[ "https://github.com/google-gemini/gemini-cli/commit/5b28f848e667dd04fc4a4b79298eb7182257da54", "https://github.com/google-gemini/gemini-cli/commit/13ef858a94b396ebac6d5839c7168509fb4649d0", "https://github.com/google-gemini/gemini-cli/commit/ca9aa6e9cf849d27eb4ba4ec7b55ede5e15219e1", "https://github.com/googl...
2025-08-29T16:20:56
0.4
TypeScript
google-gemini/gemini-cli
4,141
google-gemini__gemini-cli-4141
[ 4029 ]
c313c3dee1872a0edc943ad096eab68a03a3dda5
diff --git a/packages/core/src/core/client.ts b/packages/core/src/core/client.ts index ed903788b7a..d8143d05ac0 100644 --- a/packages/core/src/core/client.ts +++ b/packages/core/src/core/client.ts @@ -30,6 +30,7 @@ import { reportError } from '../utils/errorReporting.js'; import { GeminiChat } from './geminiChat.js'; ...
diff --git a/packages/core/src/core/client.test.ts b/packages/core/src/core/client.test.ts index bbcb549b1f3..03793bdac29 100644 --- a/packages/core/src/core/client.test.ts +++ b/packages/core/src/core/client.test.ts @@ -470,34 +470,31 @@ describe('Gemini Client (client.ts)', () => { describe('tryCompressChat', () =...
Compression can result in 400s and inability to continue conversation ### What happened? after hitting limit of tokens, the cli attempt a compress if you redo a compress afterward it fails, but then the conversation is not recoverable as it get stuck replying systematically 400 code with below message : Please ensure ...
@scidomino see linked duplicate issue I put more context there. I also encountered a similar problem. I wrote a summary reference after reading a large number of documents (~170) using Gemini. However, it may be that the free quota for the day has been used up, so I am stuck here. But in short, no matter how I use othe...
@scidomino see linked duplicate issue I put more context there. I also encountered a similar problem. I wrote a summary reference after reading a large number of documents (~170) using Gemini. However, it may be that the free quota for the day has been used up, so I am stuck here. But in short, no matter how I use othe...
[ "https://github.com/google-gemini/gemini-cli/commit/dedcea2be48dfea641f7a134e2fc946ee249572d" ]
2025-07-14T16:38:49
0.1
TypeScript
google-gemini/gemini-cli
6,397
google-gemini__gemini-cli-6397
[ 4588 ]
1a89d185269df6b492f9960c7efb140890bf75b1
diff --git a/packages/cli/src/gemini.tsx b/packages/cli/src/gemini.tsx index b285a5af223..f9cacfb7afe 100644 --- a/packages/cli/src/gemini.tsx +++ b/packages/cli/src/gemini.tsx @@ -342,7 +342,9 @@ export async function main() { } } if (!input) { - console.error('No input provided via stdin.'); + consol...
diff --git a/integration-tests/stdin-context.test.ts b/integration-tests/stdin-context.test.ts index c7c89a9110c..912fa0c2c5d 100644 --- a/integration-tests/stdin-context.test.ts +++ b/integration-tests/stdin-context.test.ts @@ -67,4 +67,31 @@ describe('stdin context', () => { 'Expected the model to identify the...
Git Bash on windows doesn't run the gemini command. ### What happened? When trying to run ```gemini``` command in a git bash terminal on windows, nothing happens. The program doesn't start the auth process, nor does it seem to even operate. The terminal just gets stale and nothing happens. Running it as administrator ...
Hey @jacob314, i have been thinking about how to solve this issue, this happens because when input is not TTY, piped input is expected but there is no piped input, this keeps the cli waiting for input from stdin. There are multiple ways to solve this issue. **Approach1**: wait for some time T, if there is no input f...
Hey @jacob314, i have been thinking about how to solve this issue, this happens because when input is not TTY, piped input is expected but there is no piped input, this keeps the cli waiting for input from stdin. There are multiple ways to solve this issue. **Approach1**: wait for some time T, if there is no input f...
[ "https://github.com/google-gemini/gemini-cli/commit/2a1ef2f18ed159d7f7638141295fc06b3dd78972", "https://github.com/google-gemini/gemini-cli/commit/4df777f61a77240bc87aa117f1b9827bf0dc210d", "https://github.com/google-gemini/gemini-cli/commit/d4febe76f83b366d3debefa485f9775146cce732", "https://github.com/googl...
2025-08-16T21:35:04
0.3
TypeScript
google-gemini/gemini-cli
7,167
google-gemini__gemini-cli-7167
[ 5239 ]
3e74ff71b7a2094b2ad23740c605a50b9b06d965
diff --git a/packages/cli/src/ui/hooks/slashCommandProcessor.ts b/packages/cli/src/ui/hooks/slashCommandProcessor.ts index c36340db11a..350df660d2a 100644 --- a/packages/cli/src/ui/hooks/slashCommandProcessor.ts +++ b/packages/cli/src/ui/hooks/slashCommandProcessor.ts @@ -393,9 +393,9 @@ export const useSlashCommandPro...
diff --git a/packages/cli/src/ui/hooks/slashCommandProcessor.test.ts b/packages/cli/src/ui/hooks/slashCommandProcessor.test.ts index 7099e2e6692..0a92a085d50 100644 --- a/packages/cli/src/ui/hooks/slashCommandProcessor.test.ts +++ b/packages/cli/src/ui/hooks/slashCommandProcessor.test.ts @@ -417,6 +417,44 @@ describe('...
If I save a chat when signed in with an API key and then try to load it when signed in with my gmail account, I get fatal errors when I try to enter another prompt. ### What happened? Enter a conversation. Can be as trivial as `1+1` `/chat save add` `/auth` `/chat resume add` Now if you type anything in the chat you g...
[ "https://github.com/google-gemini/gemini-cli/commit/2a1fa72fce76973052675b72e1278a5f02715e6e" ]
2025-08-26T23:51:39
0.2
TypeScript
google-gemini/gemini-cli
10,951
google-gemini__gemini-cli-10951
[ 10927 ]
09ef33ec3a5ea9b9d09ff0a43c6013f66bcc4641
diff --git a/packages/cli/src/nonInteractiveCli.ts b/packages/cli/src/nonInteractiveCli.ts index 9a5e5fad09e..54f9eb909ea 100644 --- a/packages/cli/src/nonInteractiveCli.ts +++ b/packages/cli/src/nonInteractiveCli.ts @@ -4,7 +4,11 @@ * SPDX-License-Identifier: Apache-2.0 */ -import type { Config, ToolCallRequestI...
diff --git a/packages/cli/src/nonInteractiveCli.test.ts b/packages/cli/src/nonInteractiveCli.test.ts index c1240cbed95..e201e850c51 100644 --- a/packages/cli/src/nonInteractiveCli.test.ts +++ b/packages/cli/src/nonInteractiveCli.test.ts @@ -9,6 +9,8 @@ import type { ToolRegistry, ServerGeminiStreamEvent, Sessi...
Bug: Non-interactive sessions do not log tool calls in session history ### What happened? When running the Gemini CLI in a non-interactive session (using the `-p` flag), tool call information is not being recorded in the automatically saved session history JSON files. However, when running in an interactive session (w...
@sniemczyk-google I have a PR in: #10951.
@sniemczyk-google I have a PR in: #10951.
[ "https://github.com/google-gemini/gemini-cli/commit/327092f9dd1abf5c455746a7f944041cc584f7dc" ]
2025-10-11T15:09:46
0.6
TypeScript
capricorn86/happy-dom
886
capricorn86__happy-dom-886
[ 875 ]
f8618cdad8e6ad08aae59c44bdddabda9d92afec
diff --git a/packages/happy-dom/src/nodes/element/HTMLCollection.ts b/packages/happy-dom/src/nodes/element/HTMLCollection.ts index b9b6ac147..eb66f68e6 100644 --- a/packages/happy-dom/src/nodes/element/HTMLCollection.ts +++ b/packages/happy-dom/src/nodes/element/HTMLCollection.ts @@ -41,7 +41,7 @@ export default class ...
diff --git a/packages/happy-dom/test/nodes/element/HTMLCollection.test.ts b/packages/happy-dom/test/nodes/element/HTMLCollection.test.ts index fb150ece0..e0fd70979 100644 --- a/packages/happy-dom/test/nodes/element/HTMLCollection.test.ts +++ b/packages/happy-dom/test/nodes/element/HTMLCollection.test.ts @@ -117,5 +117,...
RangeError: Invalid array length **Describe the bug** I use innerHTML to insert a piece of html, then error occurs. **To Reproduce** Steps to reproduce the behavior: just use node to run code below: ```js import { GlobalRegistrator } from '@happy-dom/global-registrator' GlobalRegistrator.register() document...
Thank you for reporting @lovetingyuan! :slightly_smiling_face: The issue has been fixed now. This was a pretty serious bug. Hopefully it is not common to use names or id:s with the same name as methods and properties of the HTMLCollection class. You can read more about the release here: https://github.com/ca...
Thank you for reporting @lovetingyuan! :slightly_smiling_face: The issue has been fixed now. This was a pretty serious bug. Hopefully it is not common to use names or id:s with the same name as methods and properties of the HTMLCollection class. You can read more about the release here: https://github.com/ca...
[ "https://github.com/capricorn86/happy-dom/commit/6f4e4708d02345900c81b3190266c5fc71786118" ]
2023-05-02T15:32:40
0.0
TypeScript
capricorn86/happy-dom
1,169
capricorn86__happy-dom-1169
[ 1168 ]
2d0c458c7f0aff85bab9cad8e2fea911cfa355e8
diff --git a/packages/happy-dom/src/dom-token-list/DOMTokenList.ts b/packages/happy-dom/src/dom-token-list/DOMTokenList.ts index 04b40e89c..a36a24102 100644 --- a/packages/happy-dom/src/dom-token-list/DOMTokenList.ts +++ b/packages/happy-dom/src/dom-token-list/DOMTokenList.ts @@ -2,6 +2,8 @@ import Element from '../nod...
diff --git a/packages/happy-dom/test/dom-token-list/DOMTokenList.test.ts b/packages/happy-dom/test/dom-token-list/DOMTokenList.test.ts index b57aa0149..3951c7c7a 100644 --- a/packages/happy-dom/test/dom-token-list/DOMTokenList.test.ts +++ b/packages/happy-dom/test/dom-token-list/DOMTokenList.test.ts @@ -211,4 +211,12 @...
Element.classList has empty string item when a class attribute contains multiple spaces **Describe the bug** Element.classList has empty string item when a class attribute contains multiple spaces. Multiple spaces should be compressed and Element.classList should not have empty string item. **To Reproduce** Steps...
[ "https://github.com/capricorn86/happy-dom/commit/5824775c58a4abb450f9b42a05670bb6eefa2e6a", "https://github.com/capricorn86/happy-dom/commit/1f5a30137f4ad0ee944bf5c1b2732a41be14347d", "https://github.com/capricorn86/happy-dom/commit/74c4d064191e966789d1ebade9f7617c27b3241e", "https://github.com/capricorn86/ha...
2023-11-24T07:56:00
0.0
TypeScript
capricorn86/happy-dom
1,755
capricorn86__happy-dom-1755
[ 1698 ]
0452d7cef78bce337bb4afeb87a749fd79e0c9e1
diff --git a/packages/happy-dom/src/nodes/node/NodeList.ts b/packages/happy-dom/src/nodes/node/NodeList.ts index 71b49276e..fac6bf517 100644 --- a/packages/happy-dom/src/nodes/node/NodeList.ts +++ b/packages/happy-dom/src/nodes/node/NodeList.ts @@ -38,6 +38,9 @@ class NodeList<T extends Node> { methodBinder.bind(...
diff --git a/packages/happy-dom/test/nodes/node/NodeList.test.ts b/packages/happy-dom/test/nodes/node/NodeList.test.ts index 7f7e0a81d..45d6f0c52 100644 --- a/packages/happy-dom/test/nodes/node/NodeList.test.ts +++ b/packages/happy-dom/test/nodes/node/NodeList.test.ts @@ -22,6 +22,21 @@ describe('NodeList', () => { ...
NodeList gets the first element when you pass and empty array as index **Describe the bug** When you use an empty array as an index of a NodeList it returns the first element instead of undefined. **To Reproduce** Steps to reproduce the behavior: We have the following function: ```javascript const getActiveTabTrackId ...
[ "https://github.com/capricorn86/happy-dom/commit/503c3b1cd773306a2b37c979da6780933135b430", "https://github.com/capricorn86/happy-dom/commit/4ca57415dfeaf6c3642d92b567fa304ec3496178" ]
2025-03-01T17:42:16
0.0
TypeScript
capricorn86/happy-dom
812
capricorn86__happy-dom-812
[ 811 ]
5d35044852e862b33d112fd28134a7ac99529ccc
diff --git a/packages/happy-dom/src/nodes/svg-element/SVGElement.ts b/packages/happy-dom/src/nodes/svg-element/SVGElement.ts index 664e0c10d..de8a10d74 100644 --- a/packages/happy-dom/src/nodes/svg-element/SVGElement.ts +++ b/packages/happy-dom/src/nodes/svg-element/SVGElement.ts @@ -37,11 +37,13 @@ export default clas...
diff --git a/packages/happy-dom/test/nodes/svg-element/SVGElement.test.ts b/packages/happy-dom/test/nodes/svg-element/SVGElement.test.ts new file mode 100644 index 000000000..ca06abd80 --- /dev/null +++ b/packages/happy-dom/test/nodes/svg-element/SVGElement.test.ts @@ -0,0 +1,32 @@ +import Window from '../../../src/win...
SVGElement.ownerSVGElement cannot exit if not in svg **Describe the bug** When I was using SVG nodes and tried to use the ownerSVGElement property, I ended up in an infinite loop. Upon checking the code, I found the following issue. ![image](https://user-images.githubusercontent.com/56526981/223290250-e91aadf7-aad5...
Thanks for your contribution @linghaoSu! :slightly_smiling_face:
[ "https://github.com/capricorn86/happy-dom/commit/d26bfad3fa323325eec2265b2cba68d31d3da5c5", "https://github.com/capricorn86/happy-dom/commit/22d6fdec654bb74f6d0f98eda2a5067d333bc299" ]
2023-03-07T01:15:05
0.0
TypeScript
capricorn86/happy-dom
1,911
capricorn86__happy-dom-1911
[ 1620 ]
220df23dea106ad29c60393e6ebcffe5d2ce3af7
diff --git a/packages/happy-dom/src/nodes/document/Document.ts b/packages/happy-dom/src/nodes/document/Document.ts index 241d86b91..bf6d67fcd 100644 --- a/packages/happy-dom/src/nodes/document/Document.ts +++ b/packages/happy-dom/src/nodes/document/Document.ts @@ -1472,7 +1472,7 @@ export default class Document extends...
diff --git a/packages/happy-dom/test/query-selector/QuerySelector.test.ts b/packages/happy-dom/test/query-selector/QuerySelector.test.ts index 9061490ec..05be773cf 100644 --- a/packages/happy-dom/test/query-selector/QuerySelector.test.ts +++ b/packages/happy-dom/test/query-selector/QuerySelector.test.ts @@ -1369,6 +136...
`:scope` no longer works **Describe the bug** since `happy-dom@13`, `Element` methods with selector string argument seem to no more support `:scope` selector * `.queySelector()` * `.querySelectorAll()` * `.matches()` **To Reproduce** Steps to reproduce the behavior: 1. `npm i happy-dom` 2. create this file: ...
Thank you for reporting @yukulele! There was no support for `:scope`, but query selectors returned it as a match even though it wasn't supported. This has finally been fixed by adding support for it. Thanks for your work on this @capricorn86. Unfortunately, I'm still seeing some inconsistent behavior with the `:scope`...
Thank you for reporting @yukulele! There was no support for `:scope`, but query selectors returned it as a match even though it wasn't supported. This has finally been fixed by adding support for it. Thanks for your work on this @capricorn86. Unfortunately, I'm still seeing some inconsistent behavior with the `:scope`...
[ "https://github.com/capricorn86/happy-dom/commit/503b7762fe00d49acaa1f9797ed3d8d30fa7d7cd", "https://github.com/capricorn86/happy-dom/commit/f5da5fb8c0cd27cf12d642f55d9bb776572c6935", "https://github.com/capricorn86/happy-dom/commit/5afa0d81c80bd1f3f4bc6b55026971710aa8865f" ]
2025-09-29T22:21:29
0.0
TypeScript
opensearch-project/OpenSearch-Dashboards
7,022
opensearch-project__OpenSearch-Dashboards-7022
[ 6996 ]
83317a231212d6770da9adadc20e40f65b1136dc
diff --git a/src/plugins/data/public/ui/filter_bar/filter_editor/value_input_type.tsx b/src/plugins/data/public/ui/filter_bar/filter_editor/value_input_type.tsx index 9d7709a5f667..fd1743e96c12 100644 --- a/src/plugins/data/public/ui/filter_bar/filter_editor/value_input_type.tsx +++ b/src/plugins/data/public/ui/filter_...
diff --git a/src/plugins/data/public/ui/filter_bar/filter_editor/value_input_type.test.tsx b/src/plugins/data/public/ui/filter_bar/filter_editor/value_input_type.test.tsx new file mode 100644 index 000000000000..aa4f4b4cd213 --- /dev/null +++ b/src/plugins/data/public/ui/filter_bar/filter_editor/value_input_type.test.t...
[BUG] is filter not working with numeric Scripted fields **Describe the bug** Adding filters for scripted numeric fields using `is` operator after clicking the **Add Filter** Button does not produce any result. However directly clicking on a visualization containing the required field adds the filter correctly. This ...
Was able to reproduce this bug. When we add a filter by clicking on one of the bar on the visualization, it will send the query value as number type, `"value": 66`; whhen we add a filter using `add filter` button from the filter bar, it will send the query value as string type, `"value": "66"`. The above flows ...
Was able to reproduce this bug. When we add a filter by clicking on one of the bar on the visualization, it will send the query value as number type, `"value": 66`; whhen we add a filter using `add filter` button from the filter bar, it will send the query value as string type, `"value": "66"`. The above flows ...
[ "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/d6faaa51cd3b81023b96576c0c481882afa215c5", "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/954d6e20b33bd8a46cc3a9b5e8d6453cde107382", "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/b96cd14b7c559f2bde29da...
2024-06-13T19:45:07
2.16
TypeScript
opensearch-project/OpenSearch-Dashboards
4,365
opensearch-project__OpenSearch-Dashboards-4365
[ 4321 ]
e451d137403bb2e3144ee1492810a183dade8ea1
diff --git a/CHANGELOG.md b/CHANGELOG.md index d4a160ccb9bc..b04ae7db4682 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -82,6 +82,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - Replace the use of `bluebird` in `saved_objects` plugin ([#4026](https://github.com/opensearch-project/OpenSe...
diff --git a/src/plugins/vis_type_vislib/public/vislib/components/legend/legend.test.tsx b/src/plugins/vis_type_vislib/public/vislib/components/legend/legend.test.tsx index 18192c3faa34..1038c663d0dc 100644 --- a/src/plugins/vis_type_vislib/public/vislib/components/legend/legend.test.tsx +++ b/src/plugins/vis_type_visl...
[Vis colors] Update legend colors to use ouiPaletteColorBlind()-derived scales Many OpenSearch Dashboard visualizations provide an interactive legend that provides users with a (non-OUI) color picker to alter the color associated with a particular visualization series. Not only do the available legend colors not match ...
[ "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/2e3df158d786f5780773ee42e3ee823fd23ff149", "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/74287ca5014cffd8c1ff4116595a2ad7ca0ad26b", "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/1f5f7b8d26b0cb82597f5c...
2023-06-22T21:18:09
2.9
TypeScript
opensearch-project/OpenSearch-Dashboards
10,361
opensearch-project__OpenSearch-Dashboards-10361
[ 2343, 10105 ]
5bd94df7ae0953791213fc6defd11a0085d07a4f
diff --git a/changelogs/fragments/10361.yml b/changelogs/fragments/10361.yml new file mode 100644 index 000000000000..9d9542c42e7b --- /dev/null +++ b/changelogs/fragments/10361.yml @@ -0,0 +1,2 @@ +feat: +- Add support for PATCH in dev tools ([#10361](https://github.com/opensearch-project/OpenSearch-Dashboards/pull/10...
diff --git a/src/core/test_helpers/osd_server.ts b/src/core/test_helpers/osd_server.ts index ff98a49f6999..1316833c1787 100644 --- a/src/core/test_helpers/osd_server.ts +++ b/src/core/test_helpers/osd_server.ts @@ -47,7 +47,7 @@ import { CliArgs, Env } from '../server/config'; import { Root } from '../server/root'; i...
Dev Tools should support PATCH method ### Reproduction: - Find some documentation about a scenario in OpenSearch APIs that use a PATCH command, [like](https://opensearch.org/docs/latest/security-plugin/access-control/api/#patch-role) - Get excited to try it out in your own cluster - Open Dashboards, login as an admi...
FYI @cwillum It seems that the request method simply isn't in the list here: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/06abe83e0180f391a84c742cf5594866bc747ea2/src/plugins/console/server/routes/api/console/proxy/validation_config.ts#L37-L43 Something else of note is that it looks like the ...
FYI @cwillum It seems that the request method simply isn't in the list here: https://github.com/opensearch-project/OpenSearch-Dashboards/blob/06abe83e0180f391a84c742cf5594866bc747ea2/src/plugins/console/server/routes/api/console/proxy/validation_config.ts#L37-L43 Something else of note is that it looks like the ...
[ "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/f119c2c26887893d36818913695e19f53892ca61", "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/21579578200c6923798f8f53ef055037801d801f", "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/b71fd880750f6d884110ee...
2025-08-06T21:12:46
3.3
TypeScript
opensearch-project/OpenSearch-Dashboards
9,176
opensearch-project__OpenSearch-Dashboards-9176
[ 5476 ]
53fe4c1064b776b214e5de5c2c809b921640d91a
diff --git a/changelogs/fragments/9167.yml b/changelogs/fragments/9167.yml new file mode 100644 index 000000000000..028d20a5be56 --- /dev/null +++ b/changelogs/fragments/9167.yml @@ -0,0 +1,2 @@ +fix: +- Cleanup OsdUrlStateStorage subscription in TopNav ([#9167](https://github.com/opensearch-project/OpenSearch-Dashboar...
diff --git a/src/plugins/data/public/query/state_sync/connect_to_query_state.test.ts b/src/plugins/data/public/query/state_sync/connect_to_query_state.test.ts index 034a4f218fbd..1c243c7b0ba6 100644 --- a/src/plugins/data/public/query/state_sync/connect_to_query_state.test.ts +++ b/src/plugins/data/public/query/state_s...
[BUG] ScopedHistory instance has fell out of scope for basePath: `/app/data-explorer` **Describe the bug** When we switch the query language in discover page, the console outputs the below error. On top of that, the action of navigating from discover page to another page will output a series of the following error a...
@joshuarrrr Can I try this one? @ashwin-pc here is the screenshot recording, i started the dashboard in Incognito: https://github.com/opensearch-project/OpenSearch-Dashboards/assets/43937633/7e7486f2-5980-488c-9c1f-c6b4a82fe570 Hi, is this related to my issue that the browser back button is not working like it ...
@joshuarrrr Can I try this one? @ashwin-pc here is the screenshot recording, i started the dashboard in Incognito: https://github.com/opensearch-project/OpenSearch-Dashboards/assets/43937633/7e7486f2-5980-488c-9c1f-c6b4a82fe570 Hi, is this related to my issue that the browser back button is not working like it ...
[ "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/579b0a26d52e4464c9421f33f7e94ccdf74e80b7" ]
2025-01-13T19:12:48
2.19
TypeScript
opensearch-project/OpenSearch-Dashboards
5,881
opensearch-project__OpenSearch-Dashboards-5881
[ 5692 ]
4ab0ca8cd34cea2c4bb746d32e2b00b60d671cbe
diff --git a/CHANGELOG.md b/CHANGELOG.md index 4d4a5efcb1ef..5819b11f7d41 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -42,6 +42,7 @@ Inspired from [Keep a Changelog](https://keepachangelog.com/en/1.0.0/) - [Multiple Datasource] Able to Hide "Local Cluster" option from datasource DropDown ([#5827](https://github.co...
diff --git a/src/plugins/data_source/server/client/configure_client.test.mocks.ts b/src/plugins/data_source/server/client/configure_client.test.mocks.ts index 38a585ff2020..787954a5f97b 100644 --- a/src/plugins/data_source/server/client/configure_client.test.mocks.ts +++ b/src/plugins/data_source/server/client/configur...
[Proposal] Refactoring data source plugin to support add-on authentication method with plug-in module # Overview The purpose of this design document is to outline the approach and specifications for adding an interface in multi data source plugin that allows the seamless integration of authentication method through pl...
[ "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/f332650401fcb2d0f38228ffbe293c75554be21c", "https://github.com/opensearch-project/OpenSearch-Dashboards/commit/d0b1d2b759807536fa30d31858216613fa66160a" ]
2024-02-15T22:31:15
2.12
TypeScript
vscode-neovim/vscode-neovim
1,619
vscode-neovim__vscode-neovim-1619
[ 1612, 1618 ]
48f6d5a93dbedabcbdec46a79fe37e47d1995d2b
diff --git a/src/document_change_manager.ts b/src/document_change_manager.ts index 3ba064266..d05992084 100644 --- a/src/document_change_manager.ts +++ b/src/document_change_manager.ts @@ -256,9 +256,8 @@ export class DocumentChangeManager implements Disposable { logger.debug(`No visible text e...
diff --git a/src/test/suite/basic-editing-navigation.test.ts b/src/test/suite/basic-editing-navigation.test.ts index 40b11d12e..81a3fd673 100644 --- a/src/test/suite/basic-editing-navigation.test.ts +++ b/src/test/suite/basic-editing-navigation.test.ts @@ -1,4 +1,7 @@ +import { strict as assert } from "assert"; + impo...
bug: latest dev build is pasting wrong data from buffer. ### Did you check docs and existing issues? - [X] I have read all the vscode-neovim docs - [X] I have searched the existing issues of vscode-neovim - [X] I can reproduce the issue with an empty init.vim/init.lua and no other vscode extensions (when applicable) ...
Does every file have this issue? Can you upload a file that reproduces the issue? https://github.com/rayzorben/mudengine/blob/main/src/engine/user.coffee line 572 other files seem fine but I only tested about 3 I can't reproduce 👀
Does every file have this issue? Can you upload a file that reproduces the issue? https://github.com/rayzorben/mudengine/blob/main/src/engine/user.coffee line 572 other files seem fine but I only tested about 3 I can't reproduce 👀
[ "https://github.com/vscode-neovim/vscode-neovim/commit/74ea1e9dffdedbc9970a229a0d47bcd6dad69271", "https://github.com/vscode-neovim/vscode-neovim/commit/95158fd6781ff3ca18854f31db2851f8cc28e572", "https://github.com/vscode-neovim/vscode-neovim/commit/a5939e154e0cb922f7b6eba62afdf3ad0e291613" ]
2023-11-15T14:44:53
1.0
TypeScript
vscode-neovim/vscode-neovim
1,401
vscode-neovim__vscode-neovim-1401
[ 1144, 1368, 1374 ]
242e2bdffee8c9ab883e06d0165a453d4f3e28d6
diff --git a/runtime/lua/vscode-neovim/cursor.lua b/runtime/lua/vscode-neovim/cursor.lua index dc549b897..e5d73ab22 100644 --- a/runtime/lua/vscode-neovim/cursor.lua +++ b/runtime/lua/vscode-neovim/cursor.lua @@ -90,6 +90,8 @@ function M.highlight_fake_cursor() local line = vim.fn.line(".") local col = vim.fn...
diff --git a/.github/workflows/build_test.yml b/.github/workflows/build_test.yml index 96b72ca82..74d11fde6 100644 --- a/.github/workflows/build_test.yml +++ b/.github/workflows/build_test.yml @@ -26,7 +26,8 @@ jobs: id: vim with: neovim: true - version:...
Bug: Visual mode for files makes letters appear in the line that is selected Have disabled all other plugins expect the colorscheme. https://user-images.githubusercontent.com/7727602/215477372-ce102f74-c17e-4ac6-8b82-3ab926d48320.mov bug: ghost cursor ### Did you check docs and existing issues? - [X] I have r...
I've been seeing this for a while too, possibly since the last update? Perhaps worth noting is this seems to be cosmetic — the selection will look garbled, but as far as I can tell the backing buffer has the right selection, since e.g. `vi(y` still works as expected and yank the selection. same issue, but looks like...
I've been seeing this for a while too, possibly since the last update? Perhaps worth noting is this seems to be cosmetic — the selection will look garbled, but as far as I can tell the backing buffer has the right selection, since e.g. `vi(y` still works as expected and yank the selection. same issue, but looks like...
[ "https://github.com/vscode-neovim/vscode-neovim/commit/0ebe821f612acd999344e88682f520ad16c03596", "https://github.com/vscode-neovim/vscode-neovim/commit/c6d4a2f817ce69a8534867b9ba4ae20762bf84f9", "https://github.com/vscode-neovim/vscode-neovim/commit/63676fd17d5f172a1594a3ab6c878be6d62e1798", "https://github....
2023-08-28T15:27:08
0.4
TypeScript
vscode-neovim/vscode-neovim
1,167
vscode-neovim__vscode-neovim-1167
[ 1185 ]
364aa275cd776eba3d9fdb3009261f655bfd11f1
diff --git a/src/document_change_manager.ts b/src/document_change_manager.ts index dfb94f5a0..dd4e7d1fa 100644 --- a/src/document_change_manager.ts +++ b/src/document_change_manager.ts @@ -177,11 +177,12 @@ export class DocumentChangeManager implements Disposable, NeovimExtensionRequest dotRepeatChange...
diff --git a/src/test/suite/dot-repeat.test.ts b/src/test/suite/dot-repeat.test.ts index 428ebaa87..f040eea80 100644 --- a/src/test/suite/dot-repeat.test.ts +++ b/src/test/suite/dot-repeat.test.ts @@ -14,6 +14,7 @@ import { copyVSCodeSelection, openTextDocument, sendInsertKey, + sendVSCodeKeysAtomic, ...
[Bug] vscode-neovim runs pasted code after hitting `Esc` ???!!! Repro Steps: 1. Create a file named `test.vim`. 2. Paste `map <leader> <cmd>call VSCodeNotifyVisual('editor.action.commentLine', 0)<cr><esc>` into the file. 3. Use VSCode to open it. 4. Enter insert mode. 5. Use `Cmd+A` to select all. 6. Use `Cmd+C...
This is the strangest bug I've seen recently, can you reproduce it? @justinmk I've also encountered this issue and created a [pull request with the fix](https://github.com/vscode-neovim/vscode-neovim/pull/1167) a couple of weeks ago. However, the tests are failing on Windows, and I cannot investigate the reason as I d...
[ "https://github.com/vscode-neovim/vscode-neovim/commit/9a6617cb6ddc846a29d59267e6eed60d9e602ca6", "https://github.com/vscode-neovim/vscode-neovim/commit/b94636dad773fc6f071ac8a334d62ddb77a6bb54", "https://github.com/vscode-neovim/vscode-neovim/commit/33907455f2c5d82a005f5bb845b4e58dd69100be", "https://github....
2023-03-04T14:33:33
0.8
TypeScript
vscode-neovim/vscode-neovim
1,439
vscode-neovim__vscode-neovim-1439
[ 543 ]
6d225e563cb25a6f5b1299a7668df701ecca0762
diff --git a/runtime/lua/vscode-neovim/api.lua b/runtime/lua/vscode-neovim/api.lua index acf77b5b4..4c072e227 100644 --- a/runtime/lua/vscode-neovim/api.lua +++ b/runtime/lua/vscode-neovim/api.lua @@ -1,3 +1,5 @@ +local api = vim.api +local fn = vim.fn -- used to execute vscode command local command_event_name = "vsc...
diff --git a/src/test/suite/jumplist.test.ts b/src/test/suite/jumping.test.ts similarity index 74% rename from src/test/suite/jumplist.test.ts rename to src/test/suite/jumping.test.ts index 3048b31f0..2739a5ad1 100644 --- a/src/test/suite/jumplist.test.ts +++ b/src/test/suite/jumping.test.ts @@ -1,6 +1,7 @@ import pat...
Lower-case marks lost after changes to line of mark in insert mode **Summary** It appears changing the buffer (e.g. `cw`) can mess up local marks. **Steps** Given following buffer (with cursor at `|`) ``` |Lorem ipsum dolor sit amet. ``` `ma`, `w`, `cw`, `foo`, `<esc>`, `'a` **Actual** ``` Lorem...
I did some further debugging: * Only marks of changed lines are affected (i.e. marks in other lines are not lost) * Marks are only lost if entering/exiting insert mode (e.g. `cw` not `D`) Reading debug logs and looking through the code, my best guess so far is that lines [changed](https://github.com/asvetliakov/vs...
I did some further debugging: * Only marks of changed lines are affected (i.e. marks in other lines are not lost) * Marks are only lost if entering/exiting insert mode (e.g. `cw` not `D`) Reading debug logs and looking through the code, my best guess so far is that lines [changed](https://github.com/asvetliakov/vs...
[ "https://github.com/vscode-neovim/vscode-neovim/commit/04c359f5e312e996f3f0122fe6b52888f5cb014f", "https://github.com/vscode-neovim/vscode-neovim/commit/0c942a3cf29c33943422bbbe37dcac5636483a20", "https://github.com/vscode-neovim/vscode-neovim/commit/394d9b86f2fba5423ecacae54427e7800e232909", "https://github....
2023-09-10T14:28:04
0.6
TypeScript
vscode-neovim/vscode-neovim
2,035
vscode-neovim__vscode-neovim-2035
[ 1752 ]
fbc7c0dc4c3a21ac3c801f800844b3673a32abbd
diff --git a/src/cursor_manager.ts b/src/cursor_manager.ts index aadacdaf5..d50e9c8e8 100644 --- a/src/cursor_manager.ts +++ b/src/cursor_manager.ts @@ -61,8 +61,17 @@ export class CursorManager implements Disposable { * cursor updates while entering insert mode and insert mode commands. Thus, when those events o...
diff --git a/src/test/integ/insert-mode.test.ts b/src/test/integ/insert-mode.test.ts index 0fd7b4736..8ac30f7a9 100644 --- a/src/test/integ/insert-mode.test.ts +++ b/src/test/integ/insert-mode.test.ts @@ -478,4 +478,28 @@ describe("Insert mode and buffer synchronization", () => { client, ); }...
[Bug] `ci'`, cursor jumps to the end of line OS: macOS 14 nvim: 0.9.5 vscode-nvim: 1.5.0 vscode-neovim behavior (cursor jumps to the end of the line): https://github.com/vscode-neovim/vscode-neovim/assets/28700378/238e82cd-8bfc-4e7b-a25d-1cc9b2758bde Neovim behavior (cursor stays inside the quotes): https...
#1080 Still can't reproduce @xiyaowong I tried disabling all extensions except vscode-neovim, but the issue still persists. @xiyaowong Can you share your environment info, e.g. OS, vscode version, vscode-neovim version, neovim version, etc? OS: windows 11 All are the latest versions @xiyaowong Can you try this on a Ma...
#1080 Still can't reproduce @xiyaowong I tried disabling all extensions except vscode-neovim, but the issue still persists. @xiyaowong Can you share your environment info, e.g. OS, vscode version, vscode-neovim version, neovim version, etc? OS: windows 11 All are the latest versions @xiyaowong Can you try this on a Ma...
[ "https://github.com/vscode-neovim/vscode-neovim/commit/96f6fc1b62ed91233cd84991d22b05c77802e027", "https://github.com/vscode-neovim/vscode-neovim/commit/e283917ced9f5d5e3edbc3d85b454f4e767c3990" ]
2024-05-30T14:49:13
1.1
TypeScript
vercel/ai
8,177
vercel__ai-8177
[ 7099 ]
c4eff2967ae1cbcb1cc8fd251447c664ea9b868c
diff --git a/.changeset/long-rules-leave.md b/.changeset/long-rules-leave.md new file mode 100644 index 000000000000..c926e2127e9f --- /dev/null +++ b/.changeset/long-rules-leave.md @@ -0,0 +1,5 @@ +--- +'@ai-sdk/openai': patch +--- + +fix(provider/openai): correct web search tool input diff --git a/examples/ai-core/sr...
diff --git a/packages/openai/src/responses/openai-responses-language-model.test.ts b/packages/openai/src/responses/openai-responses-language-model.test.ts index e97ba2189eb5..0ba8d860a69f 100644 --- a/packages/openai/src/responses/openai-responses-language-model.test.ts +++ b/packages/openai/src/responses/openai-respon...
Item 'rs_...' of type 'reasoning' was provided without its required following item ### Description When using the `openai.responses()` API with a reasoning model, a tool call results in an error. However, using `openai.chat()` avoids the error — but **tool calling and reasoning streaming are not available** in that ...
@lgrammel is there any hot-fix for this issue? Hi can you check the latest ai sdk 5 beta and latest ai sdk 5 beta openai provider? we made fixes in that area This is still happening in the latest beta releases @lgrammel still there ```[Error [AI_APICallError]: Item 'rs_68705394944881a0bad1de4b641bb7a80d2db2349dd4408e' ...
@lgrammel is there any hot-fix for this issue? Hi can you check the latest ai sdk 5 beta and latest ai sdk 5 beta openai provider? we made fixes in that area This is still happening in the latest beta releases @lgrammel still there ```[Error [AI_APICallError]: Item 'rs_68705394944881a0bad1de4b641bb7a80d2db2349dd4408e' ...
[ "https://github.com/vercel/ai/commit/8b4f1baa07f2a68af74af7325b1d6fb0d18c8f0b", "https://github.com/vercel/ai/commit/c5013cf59d8ad9ba392009c91ad9596d0d97f891", "https://github.com/vercel/ai/commit/5779f4b9189be954101e73d3e3b7e2c59c64de25", "https://github.com/vercel/ai/commit/bcacb0611763f30a4f5705e5d3303b95b...
2025-08-20T13:10:48
0.0
TypeScript
vercel/ai
4,939
vercel__ai-4939
[ 4920 ]
29c35b9849ac0f52c85468f055c0632b8c99fa55
diff --git a/.changeset/few-cherries-attack.md b/.changeset/few-cherries-attack.md new file mode 100644 index 000000000000..8d07fa1a0549 --- /dev/null +++ b/.changeset/few-cherries-attack.md @@ -0,0 +1,5 @@ +--- +'ai': patch +--- + +fix (ai/core): add `startWithReasoning` option to `extractReasoningMiddleware` diff --g...
diff --git a/packages/ai/core/middleware/extract-reasoning-middleware.test.ts b/packages/ai/core/middleware/extract-reasoning-middleware.test.ts index e353335b746d..72219420e209 100644 --- a/packages/ai/core/middleware/extract-reasoning-middleware.test.ts +++ b/packages/ai/core/middleware/extract-reasoning-middleware.t...
remove stray </think> tags in reasoning extractor middleware ### Description In some cases, the </think> tag is leaking into customer-facing messages. For example: ``` Assistant: "Okay, the user is reacting to the .... \n</think>" ``` this is most likely caused by out-of-order `<think>` and `</think>` tags. the midd...
[ "https://github.com/vercel/ai/commit/f50ce13e20d32edb128ca597c507be769fce5339", "https://github.com/vercel/ai/commit/7d79cd07a71fa708358aece142b74edefe6596c6", "https://github.com/vercel/ai/commit/145a1d233eee93fb171c232cbfd2417761844544", "https://github.com/vercel/ai/commit/0c2a8b0006714829edaf54a77d7f00e1f...
2025-02-19T13:29:30
0.0
TypeScript
vercel/ai
6,925
vercel__ai-6925
[ 6913 ]
8e6b69d42c637059176d9d92eba4738b6608b9ef
diff --git a/.changeset/spicy-bats-impress.md b/.changeset/spicy-bats-impress.md new file mode 100644 index 000000000000..a797c4ca3874 --- /dev/null +++ b/.changeset/spicy-bats-impress.md @@ -0,0 +1,5 @@ +--- +'@ai-sdk/openai': major +--- + +fix (provider/openai): default strict mode to false diff --git a/packages/open...
diff --git a/packages/openai/src/openai-chat-language-model.test.ts b/packages/openai/src/openai-chat-language-model.test.ts index 3cc78cd39238..555275836746 100644 --- a/packages/openai/src/openai-chat-language-model.test.ts +++ b/packages/openai/src/openai-chat-language-model.test.ts @@ -545,7 +545,7 @@ describe('doG...
V5 - Tool execute() won't infer zod schema parameters ### Description Setting up zod.object as the tool parameters result in error in the execute function. ![Image](https://github.com/user-attachments/assets/34b6af65-14fd-4e2c-878f-1d5009fd9b4e) ![Image](https://github.com/user-attachments/assets/55d35a24-8880-489b-...
Yes `parameters` is now `inputSchema`. Does it work for you now? You also need to have Zod 3.25 or newer well it does not have the type error anymore, but im getting an error from openAI when trying to use the tool... `{"error":{"message":"Invalid schema for function 'getAvailableTimeSlots': In context=(), 'required'...
Yes `parameters` is now `inputSchema`. Does it work for you now? You also need to have Zod 3.25 or newer well it does not have the type error anymore, but im getting an error from openAI when trying to use the tool... `{"error":{"message":"Invalid schema for function 'getAvailableTimeSlots': In context=(), 'required'...
[ "https://github.com/vercel/ai/commit/bff3280cdb03fad41a4d085d165349fcb93614a7", "https://github.com/vercel/ai/commit/c131e70daa417d4a884311c3afe7c6ec5e96c207", "https://github.com/vercel/ai/commit/a41945570b07b8e3b3d42780fd5e418321bb2e8c", "https://github.com/vercel/ai/commit/971516265f7a31c7f8f8a8539a9844861...
2025-06-30T08:29:34
0.0
TypeScript
vercel/ai
8,357
vercel__ai-8357
[ 8180 ]
b174437c4724191c5afcc07aef273440ef9fa5f0
diff --git a/.changeset/wise-lamps-study.md b/.changeset/wise-lamps-study.md new file mode 100644 index 000000000000..863fa6ff6445 --- /dev/null +++ b/.changeset/wise-lamps-study.md @@ -0,0 +1,5 @@ +--- +'@ai-sdk/google': patch +--- + +Fixed handling of image response in the tool call result. diff --git a/examples/ai-c...
diff --git a/packages/google/src/convert-to-google-generative-ai-messages.test.ts b/packages/google/src/convert-to-google-generative-ai-messages.test.ts index 4581cae8f5e0..98a65bbb6539 100644 --- a/packages/google/src/convert-to-google-generative-ai-messages.test.ts +++ b/packages/google/src/convert-to-google-generati...
Google models can't "see" images returned from tool calls ### Description It seems that calling`toModelOutput` when using models from `@ai-sdk/google` does not map the content properly, and the models cant "see" the images. If I ask sonnet "Whats in this image", and it calls a tool that responds with an image, sonnet...
[ "https://github.com/vercel/ai/commit/1d22f64fbddfd97e56a3dbeff6b89771cdf8b6bd", "https://github.com/vercel/ai/commit/7ed92c2728d05988d68563e5ae338aa4e25116f8", "https://github.com/vercel/ai/commit/3628816e718ee2b7e643eceba44b62b45a376bf9", "https://github.com/vercel/ai/commit/c5fcd9211237d64ac2aa2456f0e626576...
2025-08-28T22:34:14
0.0
TypeScript
vercel/ai
9,821
vercel__ai-9821
[ 9473 ]
e447eec0d2be2c44de5525ccc893abe37e244201
diff --git a/.changeset/orange-ears-itch.md b/.changeset/orange-ears-itch.md new file mode 100644 index 000000000000..7496895a4cbf --- /dev/null +++ b/.changeset/orange-ears-itch.md @@ -0,0 +1,5 @@ +--- +'@ai-sdk/openai': patch +--- + +feat(openai): preserve file_id when converting file citations diff --git a/packages/...
diff --git a/packages/openai/src/responses/__snapshots__/openai-responses-language-model.test.ts.snap b/packages/openai/src/responses/__snapshots__/openai-responses-language-model.test.ts.snap index fd8bd1495965..bbc3b00f5047 100644 --- a/packages/openai/src/responses/__snapshots__/openai-responses-language-model.test....
OpenAI provider: Preserve file_id when converting file citations to sources ### Description The OpenAI responses API returns file citations with **file_id**. This information is lost when converting file citations to sources in the content array. For example https://github.com/vercel/ai/blob/27e8c3aad8e3cdd73f5d8f454c...
This would require a spec change: https://github.com/vercel/ai/blob/0adc679a2c9c1a8b2d2af2d976666e1262dbcc59/packages/provider/src/language-model/v3/language-model-v3-source.ts#L58-L61 We'll consider it for the v6 release, as a spec change is a breaking change. Thanks! We can store it in the provider metadata. I'll ...
This would require a spec change: https://github.com/vercel/ai/blob/0adc679a2c9c1a8b2d2af2d976666e1262dbcc59/packages/provider/src/language-model/v3/language-model-v3-source.ts#L58-L61 We'll consider it for the v6 release, as a spec change is a breaking change. Thanks! We can store it in the provider metadata. I'll ...
[ "https://github.com/vercel/ai/commit/c140ecbfc1b8e39697d2b1583fad925207070bae", "https://github.com/vercel/ai/commit/a251c5bc06d075fe506b92163269b11e82cfe838", "https://github.com/vercel/ai/commit/7b408ee6a8fe93bd674d64b991384f1281e565d3", "https://github.com/vercel/ai/commit/ca49cf2cbaa5936248b7cfe397a1e0326...
2025-10-27T16:33:52
0.0
TypeScript
elastic/eui
7,156
elastic__eui-7156
[ 7038 ]
3a653d42704d087ec285d75ab21fa51424de3b5a
diff --git a/src-docs/src/views/call_out/call_out_example.js b/src-docs/src/views/call_out/call_out_example.js index feda7223691..97f563aceb3 100644 --- a/src-docs/src/views/call_out/call_out_example.js +++ b/src-docs/src/views/call_out/call_out_example.js @@ -46,6 +46,15 @@ const dangerSnippet = [ `, ]; +import On...
diff --git a/src/components/call_out/__snapshots__/call_out.test.tsx.snap b/src/components/call_out/__snapshots__/call_out.test.tsx.snap index 0813a304ab7..da1a8e37b32 100644 --- a/src/components/call_out/__snapshots__/call_out.test.tsx.snap +++ b/src/components/call_out/__snapshots__/call_out.test.tsx.snap @@ -7,7 +7,...
[EuiCallOut] Add optional close button **Is your feature request related to a problem? Please describe.** In practice, callouts can be dismissed or closed. The current docs demonstrate the use of a 'Dismiss' button below the copy and, in Kibana, we see the use of a close button in the upper-right corner (see below). ...
@ryankeairns, my thoughts below: **Dismissible prop** We could add a `dismissible: bool` prop, which adds the `Dismiss` button as well as a close icon (top right). <img width="1391" alt="Screenshot 2023-08-14 at 10 40 13" src="https://github.com/elastic/eui/assets/92029479/3e3fa0e9-7a8a-4f4b-aac7-dd38460768ea"> **::...
@ryankeairns, my thoughts below: **Dismissible prop** We could add a `dismissible: bool` prop, which adds the `Dismiss` button as well as a close icon (top right). <img width="1391" alt="Screenshot 2023-08-14 at 10 40 13" src="https://github.com/elastic/eui/assets/92029479/3e3fa0e9-7a8a-4f4b-aac7-dd38460768ea"> **::...
[ "https://github.com/elastic/eui/commit/e818cfa0c645a5339860c64da578f4bb2d5dd8a9", "https://github.com/elastic/eui/commit/a055e7903d7a81952d986e8e56c73d06579a39b2", "https://github.com/elastic/eui/commit/bbf3fa8fcbab90231c8700f064d5c3006d43fb8a", "https://github.com/elastic/eui/commit/0c29f6010bf8f0f98f1dd17fd...
2023-09-05T09:55:31
4.5
TypeScript
elastic/eui
6,883
elastic__eui-6883
[ 6857 ]
f95a3ec7594846135ad42d988d286b23fe31143f
diff --git a/src-docs/src/views/inline_edit/inline_edit_example.js b/src-docs/src/views/inline_edit/inline_edit_example.js index 5c57e1ca5ae..ebe59fa12f2 100644 --- a/src-docs/src/views/inline_edit/inline_edit_example.js +++ b/src-docs/src/views/inline_edit/inline_edit_example.js @@ -30,6 +30,14 @@ const inlineEditTitl...
diff --git a/src/components/inline_edit/__snapshots__/inline_edit_form.test.tsx.snap b/src/components/inline_edit/__snapshots__/inline_edit_form.test.tsx.snap index 752a477a9ae..73a68b09310 100644 --- a/src/components/inline_edit/__snapshots__/inline_edit_form.test.tsx.snap +++ b/src/components/inline_edit/__snapshots_...
[EuiInlineEdit] Create `placeholder` prop for Inline Edit compoents **Is your feature request related to a problem? Please describe.** The inline edit pattern in Stack Management is similar to the `EuiInlineEdit` component, however, it has two display options for `readMode`. It can either: - Display a default value t...
[ "https://github.com/elastic/eui/commit/098ee743026a461f3901f76b0b3e8b97a53c1cc1", "https://github.com/elastic/eui/commit/dd6959f54db0c5fce340287b33f60de764273ef3", "https://github.com/elastic/eui/commit/1c6aa7b5344d08f53675290908410ac709f53106", "https://github.com/elastic/eui/commit/c4459c0ad58faba8edd2882a4...
2023-06-27T19:56:49
4.5
TypeScript
elastic/eui
7,301
elastic__eui-7301
[ 7292 ]
de10c6552df38f9a17d7c9e7bb7fe4171efae879
diff --git a/src/components/datagrid/body/data_grid_row_manager.ts b/src/components/datagrid/body/data_grid_row_manager.ts index 090f4b49365..05984951216 100644 --- a/src/components/datagrid/body/data_grid_row_manager.ts +++ b/src/components/datagrid/body/data_grid_row_manager.ts @@ -6,7 +6,9 @@ * Side Public License...
diff --git a/src/components/datagrid/body/data_grid_row_manager.test.ts b/src/components/datagrid/body/data_grid_row_manager.test.ts index 8525afba21c..277d0f320ef 100644 --- a/src/components/datagrid/body/data_grid_row_manager.test.ts +++ b/src/components/datagrid/body/data_grid_row_manager.test.ts @@ -97,6 +97,24 @@ ...
[EuiDataGrid] When in memory sorting is enabled the grid zebra stripes do not render properly **Describe the bug** I have a table with one numeric and string field. When I don't sort the stripes are rendered correctly. When I am sorting then it doesn't. Check the stripes on the second screenshot and you will see t...
[ "https://github.com/elastic/eui/commit/3db357e0a69b8bc353001c634f9060bccee64909", "https://github.com/elastic/eui/commit/3373178d5a36fdbb82606110b6732271cda610e5", "https://github.com/elastic/eui/commit/7b9c9e98d08edcebd2651672a2e1f699a53ab6c9", "https://github.com/elastic/eui/commit/eae112054db0596ac012480ed...
2023-10-20T02:49:32
4.5
TypeScript
elastic/eui
7,455
elastic__eui-7455
[ 7447 ]
154014e603d0bafdcbb937000db18055804fe1b1
diff --git a/changelogs/upcoming/7455.md b/changelogs/upcoming/7455.md new file mode 100644 index 00000000000..556da2a60c7 --- /dev/null +++ b/changelogs/upcoming/7455.md @@ -0,0 +1,1 @@ +- Updated `EuiResizableButton` to allow customizing the `indicator` style with either `handle` (default) or `border` diff --git a/sr...
diff --git a/src/components/resizable_container/__snapshots__/resizable_button.test.tsx.snap b/src/components/resizable_container/__snapshots__/resizable_button.test.tsx.snap index 51f2388d3a2..a6747ad44f6 100644 --- a/src/components/resizable_container/__snapshots__/resizable_button.test.tsx.snap +++ b/src/components/...
[EuiResizableButton] Prop to switch between drag handle icon or simple border Currently, the `EuiResizableButton` component is designed to appear like our `grab` and `grabHorizontal` icons by default. When hovering, these faux icons transition to 2px wide gray border, extending the full width/height of the parent `EuiR...
@MichaelMarcialis how do you feel about keeping the slight blue tint/halo around the border in active/focus state? i.e., <img width="34" alt="" src="https://github.com/elastic/eui/assets/549407/e039039e-d1c5-4833-8c09-a06b211b3a28"> I personally kind of like it for greater visibility. WDYT? This is not a strict o...
@MichaelMarcialis how do you feel about keeping the slight blue tint/halo around the border in active/focus state? i.e., <img width="34" alt="" src="https://github.com/elastic/eui/assets/549407/e039039e-d1c5-4833-8c09-a06b211b3a28"> I personally kind of like it for greater visibility. WDYT? This is not a strict o...
[ "https://github.com/elastic/eui/commit/2c0a7cce51381d2029114bbefaa687d04094a4f6", "https://github.com/elastic/eui/commit/56121d00be072affe02cd4fe25e17012b204643d", "https://github.com/elastic/eui/commit/b400720eac34d05abf2082ebab415bbe3f1e81c5", "https://github.com/elastic/eui/commit/c8fd6f7b687fb4504693b128b...
2024-01-09T23:05:06
4.5
TypeScript
elastic/eui
7,133
elastic__eui-7133
[ 7124 ]
d08c9ab996f9531dc6cfee3418d242a4fff07537
diff --git a/src-docs/src/views/theme/typography/_typography_js.tsx b/src-docs/src/views/theme/typography/_typography_js.tsx index c54793b46a2..354c7c5bd34 100644 --- a/src-docs/src/views/theme/typography/_typography_js.tsx +++ b/src-docs/src/views/theme/typography/_typography_js.tsx @@ -1,6 +1,6 @@ import React, { Fu...
diff --git a/src/global_styling/functions/__snapshots__/typography.test.tsx.snap b/src/global_styling/functions/__snapshots__/typography.test.tsx.snap new file mode 100644 index 00000000000..3c300bdafab --- /dev/null +++ b/src/global_styling/functions/__snapshots__/typography.test.tsx.snap @@ -0,0 +1,45 @@ +// Jest Sna...
Support specifying `_FontScaleOptions` globally **Is your feature request related to a problem? Please describe.** I'm currently developing a browser extension. In my extension, I use Shadow DOM to isolate styles to ensure my extensions render correctly in various web environments. However, I've run into an issue th...
Labeling this as high priority and low effort. We think this would be a quick win so plan to address this shortly. Thank you for the issue submission @y1j2x34. The EUI team is working on this in a related pull request.
Labeling this as high priority and low effort. We think this would be a quick win so plan to address this shortly. Thank you for the issue submission @y1j2x34. The EUI team is working on this in a related pull request. > Thank you for the issue submission @y1j2x34. The EUI team is working on this in a related pull requ...
[ "https://github.com/elastic/eui/commit/22e8e98c9280f7c49188685b2b25940845362c98", "https://github.com/elastic/eui/commit/79c59a65a2e75a0815c90963ca6775ee2be0f1a9", "https://github.com/elastic/eui/commit/6e93f4413e92bbe5f7373e9a4c7531354520e837", "https://github.com/elastic/eui/commit/648e3b23054ddba6a225fe65a...
2023-08-28T19:41:12
4.5
TypeScript
getsentry/sentry-javascript
15,138
getsentry__sentry-javascript-15138
[ 15137 ]
6ba90518942fd729c9578e7a91a3ffade8b5ef34
diff --git a/packages/node/src/integrations/anr/worker.ts b/packages/node/src/integrations/anr/worker.ts index 8900b423710b..2eebfe40309b 100644 --- a/packages/node/src/integrations/anr/worker.ts +++ b/packages/node/src/integrations/anr/worker.ts @@ -46,7 +46,13 @@ async function sendAbnormalSession(): Promise<void> { ...
diff --git a/dev-packages/node-integration-tests/suites/anr/basic-session.js b/dev-packages/node-integration-tests/suites/anr/basic-session.js index 9700131a6040..7971d547c884 100644 --- a/dev-packages/node-integration-tests/suites/anr/basic-session.js +++ b/dev-packages/node-integration-tests/suites/anr/basic-session....
[v9] Node ANR sessions missing `attrs.release` ### Description Suspect this was caused by: - https://github.com/getsentry/sentry-javascript/pull/14658 We continually pass the session to the ANR worker where it is expected to already have `attrs.release`. The session can then sent from the ANR worker later. This was ...
[ "https://github.com/getsentry/sentry-javascript/commit/80c63a4e1942709e792cd0c4d9f7dd6ae94b1f36" ]
2025-01-22T18:40:13
3.13
TypeScript
getsentry/sentry-javascript
14,218
getsentry__sentry-javascript-14218
[ 14158 ]
a91a5ba70f36a51c486cd9acee24b1b1838ffa93
diff --git a/packages/core/src/trpc.ts b/packages/core/src/trpc.ts index 366a0ba9aa62..fbcdf5832b46 100644 --- a/packages/core/src/trpc.ts +++ b/packages/core/src/trpc.ts @@ -1,7 +1,7 @@ import { normalize } from '@sentry/utils'; -import { getClient } from './currentScopes'; -import { captureException, setContext } ...
diff --git a/dev-packages/e2e-tests/test-applications/nextjs-t3/tests/trpc-error.test.ts b/dev-packages/e2e-tests/test-applications/nextjs-t3/tests/trpc-error.test.ts index 0245b641db5c..d3e175e0558b 100644 --- a/dev-packages/e2e-tests/test-applications/nextjs-t3/tests/trpc-error.test.ts +++ b/dev-packages/e2e-tests/te...
Add trpc path to context in trpcMiddleware ### Problem Statement It would make it easier to debug if I can see which trpc route is causing an issue. The current trpc route only add procedure type and input to the context. ### Solution Brainstorm Simply add path to trpc context in this function would likely work? htt...
So we do attach the path to spans if you have tracing enabled, but I think it also makes sense to add it as context. would you be open to create a PR to add this? > So we do attach the path to spans if you have tracing enabled, but I think it also makes sense to add it as context. > > would you be open to create a PR...
So we do attach the path to spans if you have tracing enabled, but I think it also makes sense to add it as context. would you be open to create a PR to add this? > So we do attach the path to spans if you have tracing enabled, but I think it also makes sense to add it as context. > > would you be open to create a PR...
[ "https://github.com/getsentry/sentry-javascript/commit/d2af0e1a98379efdf8bd52f0876efe1a224a9171", "https://github.com/getsentry/sentry-javascript/commit/68999c9299ac7654c637634a20357cee719f6aab" ]
2024-11-10T04:15:00
3.13
TypeScript
getsentry/sentry-javascript
16,033
getsentry__sentry-javascript-16033
[ 15965 ]
d007407c2e51d93d6d3933f9dea1e03ff3f4a4ab
diff --git a/packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts b/packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts index ce45f57a8db3..d34b5394945e 100644 --- a/packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts +++ b/packages/react-router/src/vite/buildEnd/handleOnBuildEnd.ts @@ -28,12 +28...
diff --git a/packages/react-router/test/vite/buildEnd/handleOnBuildEnd.test.ts b/packages/react-router/test/vite/buildEnd/handleOnBuildEnd.test.ts index e183a4b1c14a..ace8695ec209 100644 --- a/packages/react-router/test/vite/buildEnd/handleOnBuildEnd.test.ts +++ b/packages/react-router/test/vite/buildEnd/handleOnBuildE...
[RR7] url in unstable_sentryVitePluginOptions is ignored in React Router Vite plugin ### Is there an existing issue for this? - [x] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues - [x] I have reviewed the documentation https://docs.sentry.io/ - [x] I am using the latest SDK re...
Thanks for reporting! We'll fix that at some point soon-ish. For now please use the `SENTRY_URL` environment variable workaround.
Thanks for reporting! We'll fix that at some point soon-ish. For now please use the `SENTRY_URL` environment variable workaround. ## A PR closing this issue has just been released 🚀 This issue was referenced by PR #16033, which was included in the [9.13.0 release](https://github.com/getsentry/sentry-javascript/releas...
[ "https://github.com/getsentry/sentry-javascript/commit/81030413abe78624cc6ab175a07268763ffeba71" ]
2025-04-11T09:34:37
3.13
TypeScript
getsentry/sentry-javascript
17,817
getsentry__sentry-javascript-17817
[ 17804 ]
e966cdc00fcecafc8aeecefca416d60efc61cfd4
diff --git a/CHANGELOG.md b/CHANGELOG.md index fe9ab44858c1..358078c1fc7a 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,13 @@ - "You miss 100 percent of the chances you don't take. — Wayne Gretzky" — Michael Scott +### Important Changes + +- **fix(aws-serverless): Take `http_proxy` into account when choo...
diff --git a/packages/aws-serverless/test/init.test.ts b/packages/aws-serverless/test/init.test.ts index 576257e3f3e4..e6a675ecc43f 100644 --- a/packages/aws-serverless/test/init.test.ts +++ b/packages/aws-serverless/test/init.test.ts @@ -1,6 +1,6 @@ import { getSDKSource } from '@sentry/core'; import { initWithoutDe...
Errors not sent when using an AWS lambda with a http proxy and the sentry lambda layer ### Is there an existing issue for this? - [x] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues - [x] I have reviewed the documentation https://docs.sentry.io/ - [x] I am using the latest SDK ...
<p><a href="https://linear.app/getsentry/issue/JS-999/errors-not-sent-when-using-an-aws-lambda-with-a-http-proxy-and-the">JS-999 Errors not sent when using an AWS lambda with a http proxy and the sentry lambda layer</a></p> For a workaround for this I'm just using the version before [the lambda extension was turned on ...
<p><a href="https://linear.app/getsentry/issue/JS-999/errors-not-sent-when-using-an-aws-lambda-with-a-http-proxy-and-the">JS-999 Errors not sent when using an AWS lambda with a http proxy and the sentry lambda layer</a></p> For a workaround for this I'm just using the version before [the lambda extension was turned on ...
[ "https://github.com/getsentry/sentry-javascript/commit/53e333f1b6dd90a0b678ec05061ce1f508b65d11" ]
2025-09-29T15:45:06
3.13
TypeScript
getsentry/sentry-javascript
11,811
getsentry__sentry-javascript-11811
[ 11766 ]
7759d18381bd574710ff45383b51437f61d19940
diff --git a/packages/node/src/cron/cron.ts b/packages/node/src/cron/cron.ts index 8b6fc324a7a6..ce6225ced2fa 100644 --- a/packages/node/src/cron/cron.ts +++ b/packages/node/src/cron/cron.ts @@ -1,4 +1,4 @@ -import { withMonitor } from '@sentry/core'; +import { captureException, withMonitor } from '@sentry/core'; impo...
diff --git a/dev-packages/node-integration-tests/package.json b/dev-packages/node-integration-tests/package.json index 51d1eccace80..f944816fd31c 100644 --- a/dev-packages/node-integration-tests/package.json +++ b/dev-packages/node-integration-tests/package.json @@ -49,6 +49,8 @@ "mongoose": "^5.13.22", "mysq...
node-cron and node-schedule fire checkin only on app start ### Is there an existing issue for this? - [X] I have checked for existing issues https://github.com/getsentry/sentry-javascript/issues - [X] I have reviewed the documentation https://docs.sentry.io/ - [X] I am using the latest SDK release https://github.com/g...
[ "https://github.com/getsentry/sentry-javascript/commit/6a5684144505c69461cf1e66eace701ae5fe7aee", "https://github.com/getsentry/sentry-javascript/commit/f699be9af4cff17b3708cf19d0eeccf5749c4b14", "https://github.com/getsentry/sentry-javascript/commit/2dcd126bf505d83d4ff5c6fbd4762349b5c56a47", "https://github....
2024-04-26T12:45:57
3.13
TypeScript
getsentry/sentry-react-native
3,727
getsentry__sentry-react-native-3727
[ 3724 ]
a5fdf556822f33677ca587bd82dbf54cc4d46e72
diff --git a/CHANGELOG.md b/CHANGELOG.md index e8fe8f27d8..996893e939 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -9,6 +9,7 @@ ### Fixes - Do not enable NativeFramesTracking when native is not available ([#3705](https://github.com/getsentry/sentry-react-native/pull/3705)) +- Cancel spans in background doesn't c...
diff --git a/test/tracing/reactnativetracing.test.ts b/test/tracing/reactnativetracing.test.ts index ce87565a22..183f963660 100644 --- a/test/tracing/reactnativetracing.test.ts +++ b/test/tracing/reactnativetracing.test.ts @@ -127,6 +127,13 @@ describe('ReactNativeTracing', () => { beforeEach(() => { jest.useFa...
Enabling Sentry.ReactNativeTracing results in Cannot read properties of undefined (reading 'remove') when sending error. **OS:** - [x] Windows - [x] Linux **Platform:** - [ ] iOS - [x] Android **SDK:** - [x] `@sentry/react-native` (>= 1.0.0) **SDK version:** 5.19.1 **`react-native` version:** 0.73...
I have the same issue. Hi, thank you for the message @the-simian and @daehyeonmun2021. I was able to reproduce this with `react-native-web`. Can you confirm it happens on the web or do you experience it also on Android or iOS with or without Expo Go?
I have the same issue. Hi, thank you for the message @the-simian and @daehyeonmun2021. I was able to reproduce this with `react-native-web`. Can you confirm it happens on the web or do you experience it also on Android or iOS with or without Expo Go? This happens in Android on Expo Go as well as the Dev Client Buil...
[ "https://github.com/getsentry/sentry-react-native/commit/7111a1616a29b4732b3dc9b5cfbbd43bef7ca4c9" ]
2024-04-02T09:48:42
0.40
TypeScript
getsentry/sentry-react-native
5,081
getsentry__sentry-react-native-5081
[ 4705 ]
21c9e756985e1b5e4c0c65d1bb24c5fa2ad6f63e
diff --git a/CHANGELOG.md b/CHANGELOG.md index cdd58117b5..55b0eef84f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -8,6 +8,7 @@ ## Unreleased + ### Important Changes - **fix(browser): Ensure IP address is only inferred by Relay if `sendDefaultPii` is `true`** ([#5092](https://github.com/getsentry/sentry-rea...
diff --git a/packages/core/test/tracing/timetodisplay.test.tsx b/packages/core/test/tracing/timetodisplay.test.tsx index 43413abcbc..77b2a499a4 100644 --- a/packages/core/test/tracing/timetodisplay.test.tsx +++ b/packages/core/test/tracing/timetodisplay.test.tsx @@ -7,7 +7,6 @@ jest.mock('../../src/js/wrapper', () => m...
Implement TTID/TTFD as Turbo Modules https://docs.sentry.io/platforms/react-native/tracing/instrumentation/time-to-display/ TimeToDisplay component is currently implemented as a legacy native component, and needs to be re-implemented as a turbo module the way it's done in this PR for Mask/Unmask: https://github.com/ge...
[ "https://github.com/getsentry/sentry-react-native/commit/dcf217cce9368d9f7eb2d8ae15b804bc5ae21d31", "https://github.com/getsentry/sentry-react-native/commit/f0bf3b67ce0f68f9381f764824b2aa8344cc9bcf", "https://github.com/getsentry/sentry-react-native/commit/bac28d566804e027f00b4b8603a8a4954b9f780b", "https://g...
2025-08-14T10:16:53
0.40
TypeScript
getsentry/sentry-react-native
4,211
getsentry__sentry-react-native-4211
[ 3706 ]
c639edf12520d1afee79e1ff2ba18df03ce70ec3
diff --git a/CHANGELOG.md b/CHANGELOG.md index 3118925cc1..ef2aade826 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -12,6 +12,10 @@ - Enhanced accuracy of time-to-display spans. ([#4189](https://github.com/getsentry/sentry-react-native/pull/4189)) +### Features + +- Enables Spotlight in Android and iOS SDKs ([#4...
diff --git a/packages/core/RNSentryAndroidTester/app/src/test/java/io/sentry/react/RNSentryModuleImplTest.kt b/packages/core/RNSentryAndroidTester/app/src/test/java/io/sentry/react/RNSentryModuleImplTest.kt index 5a6585ab80..f699f0d530 100644 --- a/packages/core/RNSentryAndroidTester/app/src/test/java/io/sentry/react/R...
Enable Spotlight in Android and iOS SDKs ### Description At the moment Spotlight is only enabled in the JS layer of React Native. Since Android and iOS also support sending events to Spotlight we can enable the native integrations from React Native. When Spotlight is enabled in RN, it should be automatically enabl...
[ "https://github.com/getsentry/sentry-react-native/commit/5c65d805513d1a3db7e78e6ca3ed73e6abeb797d", "https://github.com/getsentry/sentry-react-native/commit/00f43e6e6ac12ffc48f548ec843a892b4ec42bf6", "https://github.com/getsentry/sentry-react-native/commit/e8cf604b7773b733cc9d1cb801257f7c6cf70504", "https://g...
2024-10-28T17:08:23
0.40
TypeScript
getsentry/sentry-react-native
2,891
getsentry__sentry-react-native-2891
[ 2879 ]
8a53c0d7655061bf60f773f616fef53953cd3dc6
diff --git a/CHANGELOG.md b/CHANGELOG.md index 9a8bd5c53b..68301d0058 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Unreleased +### Fixes + +- Remove non URL `frame.abs_path` which was causing source maps to fail ([#2891](https://github.com/getsentry/sentry-react-native/pull/2891)) + ### Depend...
diff --git a/test/integrations/rewriteframes.test.ts b/test/integrations/rewriteframes.test.ts new file mode 100644 index 0000000000..46fe540b9c --- /dev/null +++ b/test/integrations/rewriteframes.test.ts @@ -0,0 +1,715 @@ +import type { Exception } from '@sentry/browser'; +import { defaultStackParser, eventFromExcepti...
The `abs_path` of the stack frame is `index.android.bundle` which is not a valid URL **OS:** - [ ] Windows - [ ] MacOS - [x] Linux **Platform:** - [ ] iOS - [x] Android **SDK:** - [x] `@sentry/react-native` (>= 1.0.0) - [ ] `react-native-sentry` (<= 0.43.2) **SDK version:** 5.1.0 **`react-nati...
I'm seeing this as well in my react native android build. `@sentry/react-native`: `^5.1.0` `react-native`: `0.69.7` hermes has also been enabled by default, which might be a factor. My attempts at manually uploading and automatically uploading both have led to the same error. Same here. `@sentry/react-nativ...
I'm seeing this as well in my react native android build. `@sentry/react-native`: `^5.1.0` `react-native`: `0.69.7` hermes has also been enabled by default, which might be a factor. My attempts at manually uploading and automatically uploading both have led to the same error. Same here. `@sentry/react-nativ...
[ "https://github.com/getsentry/sentry-react-native/commit/6a371c4f7c0f20050c7d86fe2f081ea947d2c42b", "https://github.com/getsentry/sentry-react-native/commit/6b5af758e02d5797559c44e47da89ed4373d54ac", "https://github.com/getsentry/sentry-react-native/commit/2ef5ab7d76538c68d460d46a329aa1b9f627a0c5", "https://g...
2023-03-13T13:51:51
0.40
TypeScript
getsentry/sentry-react-native
4,298
getsentry__sentry-react-native-4298
[ 4121 ]
e8464dbfbfde63763cb80dc920a20b8dbba04e5a
diff --git a/CHANGELOG.md b/CHANGELOG.md index 135738a416..6e7c417a42 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,6 +6,13 @@ > make sure you follow our [migration guide](https://docs.sentry.io/platforms/react-native/migration/) first. <!-- prettier-ignore-end --> +## Unreleased + +### Fixes + +- Remove `.sen...
diff --git a/packages/core/test/tools/metroconfig.test.ts b/packages/core/test/tools/metroconfig.test.ts index 24135932d8..3c8a9a10b3 100644 --- a/packages/core/test/tools/metroconfig.test.ts +++ b/packages/core/test/tools/metroconfig.test.ts @@ -1,16 +1,5 @@ -jest.mock('fs', () => { - return { - readFile: jest.fn(...
Fix concurrent runs with Sentry Babel transformer **OS:** - [ ] Windows - [x] MacOS - [ ] Linux **Platform:** - [x] iOS - [ ] Android **SDK:** - [x] `@sentry/react-native` (>= 1.0.0) - [ ] `react-native-sentry` (<= 0.43.2) **SDK version:** 5.30.0 **`react-native` version:** 0.72.12 **Are you using Expo?** -...
if i comment this line. There is no error but the file can not be deleted automatically. ``` function withSentryBabelTransformer(config) { const defaultBabelTransformerPath = config.transformer && config.transformer.babelTransformerPath; utils_1.logger.debug('Default Babel transformer path from `config.transfor...
if i comment this line. There is no error but the file can not be deleted automatically. ``` function withSentryBabelTransformer(config) { const defaultBabelTransformerPath = config.transformer && config.transformer.babelTransformerPath; utils_1.logger.debug('Default Babel transformer path from `config.transfor...
[ "https://github.com/getsentry/sentry-react-native/commit/060461b34243320107770abdca8eb47bd758f5d2", "https://github.com/getsentry/sentry-react-native/commit/30de8bcd8a81c2585c145e923898b8dcace59191" ]
2024-11-20T17:21:18
0.40
TypeScript
h3js/h3
830
h3js__h3-830
[ 705 ]
c727a98ef3d5a1c1a02dbb1c2a029e7f9d4cbd12
diff --git a/package.json b/package.json index e140afe53..172ee2fd5 100644 --- a/package.json +++ b/package.json @@ -40,7 +40,7 @@ "test:types": "tsc --noEmit --skipLibCheck" }, "dependencies": { - "cookie-es": "^1.1.0", + "cookie-es": "^1.2.1", "iron-webcrypto": "^1.2.1", "ohash": "^1.1.3", ...
diff --git a/test/cookie.test.ts b/test/cookie.test.ts index 29535343d..e424141b9 100644 --- a/test/cookie.test.ts +++ b/test/cookie.test.ts @@ -80,4 +80,20 @@ describe("", () => { expect(result.text).toBe("200"); }); }); + + it("can merge unique cookies", async () => { + ctx.app.use("/", (event) => ...
Merge set cookie value for same name multiple times ### Environment Nuxt 3.10.3 with Nitro 2.9.1 Node 20.10.0 ### Reproduction ```js setCookie(e, 'session', '123', { httpOnly: true }) // ... setCookie(e, 'session', '123', { httpOnly: true, maxAge: /* 1m */ 60 * 60 * 24 * 30 }) ``` ### Describe the bug wil...
send only the last value, or merge the session options would be more reasonable. Issues with merging cookies will be solved in upcoming h3 v2
send only the last value, or merge the session options would be more reasonable. Issues with merging cookies will be solved in upcoming h3 v2
[ "https://github.com/h3js/h3/commit/edaebd2fb1c9cdc603497b1133cd32063af87061", "https://github.com/h3js/h3/commit/384b868b94f0a69e4cebaceebcc690ce397cac27" ]
2024-07-18T22:06:14
1.8
TypeScript
h3js/h3
368
h3js__h3-368
[ 354 ]
03243bab1c5db92ec615fff073101114e104103c
diff --git a/src/utils/proxy.ts b/src/utils/proxy.ts index 6e3928506..a69438135 100644 --- a/src/utils/proxy.ts +++ b/src/utils/proxy.ts @@ -12,6 +12,7 @@ export interface ProxyOptions { sendStream?: boolean; cookieDomainRewrite?: string | Record<string, string>; cookiePathRewrite?: string | Record<string, str...
diff --git a/test/proxy.test.ts b/test/proxy.test.ts index 3a5c458c4..6817e24b0 100644 --- a/test/proxy.test.ts +++ b/test/proxy.test.ts @@ -341,4 +341,75 @@ describe("", () => { ); }); }); + + describe("onResponse", () => { + beforeEach(() => { + app.use( + "/debug", + eventHandle...
Add `onResponse` callback to `sendProxy` and `proxyRequest` ### Describe the feature Sometimes it is necessary to add/modify headers for proxy response. For example, we need to add some header or remove `secure` attribute from the cookie. I suggest to add `onResponse` callback to `sendProxy` and `proxyRequest` (si...
I think its better to upgrade `proxyRequest` to make it return modified response instead of sending response directly from method. @pi0 @oleghalin I guess by "response" you mean - to return the modified `event` (with filtered headers, modified cookies etc.)? But event is already modified after we call `sendProxy`, bec...
I think its better to upgrade `proxyRequest` to make it return modified response instead of sending response directly from method. @pi0 @oleghalin I guess by "response" you mean - to return the modified `event` (with filtered headers, modified cookies etc.)? But event is already modified after we call `sendProxy`, bec...
[ "https://github.com/h3js/h3/commit/17c3ff3f57bd602dca26d808a8163a55dd592569", "https://github.com/h3js/h3/commit/e0dfee4cc3aeb141eeccc4a74704c9b6dbca18c4" ]
2023-03-29T21:18:36
1.6
TypeScript
h3js/h3
403
h3js__h3-403
[ 381 ]
6fd36cf40f0bf8ce3433b82af2fdae1bd1803417
diff --git a/src/utils/body.ts b/src/utils/body.ts index 52cd9150a..382d7b993 100644 --- a/src/utils/body.ts +++ b/src/utils/body.ts @@ -30,9 +30,15 @@ export function readRawBody<E extends Encoding = "utf8">( (event.node.req as any)[RawBodySymbol] || (event.node.req as any).body; /* unjs/unenv #8 */ if (_...
diff --git a/test/body.test.ts b/test/body.test.ts index 53069d97b..24e0b8774 100644 --- a/test/body.test.ts +++ b/test/body.test.ts @@ -194,6 +194,26 @@ describe("", () => { expect(result.text).toBe("200"); }); + it("handle readBody with Object type (unenv)", async () => { + app.use( + "/"...
[nuxt] [request error] [unhandled] [500] The first argument must be of type string or an instance of Buffer, ArrayBuffer, or Array or an Array-like Object. Received an instance of Promise ### Environment node: v16.17 nuxt: 3.4.2 nitro: 2.3.3 ### Reproduction Nuxt API requests using useAsyncData + $fetch in f...
Would you be able to provide a reproduction? 🙏 @danielroe this would be sort of a clone in terms of npm packages and env setup I have, but I cannot reproduce the issue on codesandbox. (note I have some `resolutions` on `package.json` to force some version to what I have locally) https://codesandbox.io/p/sandbox/hell...
Would you be able to provide a reproduction? 🙏 @danielroe this would be sort of a clone in terms of npm packages and env setup I have, but I cannot reproduce the issue on codesandbox. (note I have some `resolutions` on `package.json` to force some version to what I have locally) https://codesandbox.io/p/sandbox/hell...
[ "https://github.com/h3js/h3/commit/f382ab4cc4bd824c8e4107bf4cf6ffd91ec2e8d6", "https://github.com/h3js/h3/commit/3703b6344ff8a7096d6046c2a5dd05d7ad190766" ]
2023-06-09T16:23:27
1.7
TypeScript
h3js/h3
655
h3js__h3-655
[ 581 ]
3a2118d4e1797a92a76443a65176ffcfaa677064
diff --git a/docs/2.utils/2.reponse.md b/docs/2.utils/2.reponse.md index a1b2acb9f..8342433b8 100644 --- a/docs/2.utils/2.reponse.md +++ b/docs/2.utils/2.reponse.md @@ -65,6 +65,35 @@ Remove a response header by name. Directly send a response to the client. **Note:** This function should be used only when you want to...
diff --git a/test/iteratable.test.ts b/test/iteratable.test.ts new file mode 100644 index 000000000..43bc40771 --- /dev/null +++ b/test/iteratable.test.ts @@ -0,0 +1,153 @@ +import { ReadableStream } from "node:stream/web"; +import supertest, { SuperTest, Test } from "supertest"; +import { describe, it, expect, beforeE...
Support for `AsyncGenerator` event handlers, for streaming long running responses ### Describe the feature Provide a new utility that enables developers to write streamed, chunked or partial responses using an async generator: ```typescript async function delay<T>(ms, result:T) : Promise<T> { return new Promi...
Seems a nice thing to support! I'd like to help out with the PR for this. The main problem I forsee in helping to implement this is that I don't have as wide a range of experience with the ways that h3 (and nitro) are commonly used. Like, the pitfalls to avoid or defend against in the code. Regardless, I'll get star...
Seems a nice thing to support! I'd like to help out with the PR for this. The main problem I forsee in helping to implement this is that I don't have as wide a range of experience with the ways that h3 (and nitro) are commonly used. Like, the pitfalls to avoid or defend against in the code. Regardless, I'll get star...
[ "https://github.com/h3js/h3/commit/251ad903036b5f5074d5a84e058e5fd3d16655bf", "https://github.com/h3js/h3/commit/e83cbb921661a6387a8e1e579589a2966ca81587", "https://github.com/h3js/h3/commit/e9974e72a3fbac89087d5ba3ecf084d1c7a921f5", "https://github.com/h3js/h3/commit/f45b376bd079077b61384bb37655683ace209c4d"...
2024-02-21T09:56:34
1.8
TypeScript
h3js/h3
313
h3js__h3-313
[ 283 ]
080bf53d69b8193c4e22c873522d658dbda16656
diff --git a/README.md b/README.md index 3f78992a1..a6a36d2e6 100644 --- a/README.md +++ b/README.md @@ -110,6 +110,19 @@ app.use(eventHandler(() => '<h1>Hello world!</h1>')) app.use('/1', eventHandler(() => '<h1>Hello world!</h1>')) .use('/2', eventHandler(() => '<h1>Goodbye!</h1>')) +// We can proxy requests a...
diff --git a/test/proxy.test.ts b/test/proxy.test.ts index 721175852..3a5c458c4 100644 --- a/test/proxy.test.ts +++ b/test/proxy.test.ts @@ -9,6 +9,7 @@ import { eventHandler, getHeaders, getMethod, + setHeader, readRawBody, setCookie, } from "../src"; @@ -130,4 +131,214 @@ describe("", () => { ...
Add `cookieDomainRewrite`, `cookiePathRewrite` options to `sendProxy` and `proxyRequest` ### Describe the feature Usually, when using proxy, it is necessary to rewrite `domain` and `path` attributes in `set-cookie` headers. I suggest to add `cookieDomainRewrite` and `cookiePathRewrite` options to `proxyRequest` (sim...
[ "https://github.com/h3js/h3/commit/0b9f6616bf734100e435384cc01c42361e75453d", "https://github.com/h3js/h3/commit/0861bb416f24a2630cbe56e9aa9915238f12ed50", "https://github.com/h3js/h3/commit/a450d8f224c79a15ed2c0322decc25802d860c7f" ]
2023-02-05T00:03:42
1.6
TypeScript
web-infra-dev/rsbuild
447
web-infra-dev__rsbuild-447
[ 444 ]
9ffb36b75b8180cda22e5e09276482447b65e9ae
diff --git a/.changeset/orange-scissors-bathe.md b/.changeset/orange-scissors-bathe.md new file mode 100644 index 0000000000..737429f47c --- /dev/null +++ b/.changeset/orange-scissors-bathe.md @@ -0,0 +1,6 @@ +--- +'@rsbuild/shared': patch +'@rsbuild/core': patch +--- + +refactor: simplify rsbuild dev-related configura...
diff --git a/e2e/cases/dev/dev.test.ts b/e2e/cases/dev/dev.test.ts index b5895c6f97..e015c25789 100644 --- a/e2e/cases/dev/dev.test.ts +++ b/e2e/cases/dev/dev.test.ts @@ -16,12 +16,10 @@ test('default & hmr (default true)', async ({ page }) => { }, plugins: [pluginReact()], rsbuildConfig: { - tools:...
[Feature]: simplify rsbuild dev-related configurations ### What problem does this feature solve? There are some duplications between `dev` and `tools.devServer` configurations, and some modern.js `tools.devServer` configurations are not yet supported by rsbuild. in modern.js: <div style="display:flex"> <img w...
[ "https://github.com/web-infra-dev/rsbuild/commit/69ec4f723378209311820d419287ce6aa1fd01c0", "https://github.com/web-infra-dev/rsbuild/commit/c5271a660e226ca96ae240dcbcafc4b0fb13d6d6" ]
2023-11-10T09:29:06
0.0
TypeScript
web-infra-dev/rsbuild
2,795
web-infra-dev__rsbuild-2795
[ 2787 ]
bb87515127f17154b031f787c5e13e202b78bfac
diff --git a/packages/core/src/config.ts b/packages/core/src/config.ts index c599fa7241..bdfe236893 100644 --- a/packages/core/src/config.ts +++ b/packages/core/src/config.ts @@ -32,7 +32,6 @@ import { HMR_SOCKET_PATH, HTML_DIST_DIR, IMAGE_DIST_DIR, - JS_DIST_DIR, MEDIA_DIST_DIR, ROOT_DIST_DIR, SVG_D...
diff --git a/packages/core/tests/__snapshots__/environments.test.ts.snap b/packages/core/tests/__snapshots__/environments.test.ts.snap index 3fc2f52ef8..12cd899501 100644 --- a/packages/core/tests/__snapshots__/environments.test.ts.snap +++ b/packages/core/tests/__snapshots__/environments.test.ts.snap @@ -170,7 +170,7 ...
[Bug][1.0.0-alpha.2]: filename in multi-environments does not work ### Version ```sh System: OS: macOS 14.5 CPU: (10) arm64 Apple M1 Max Memory: 131.17 MB / 32.00 GB Shell: 5.9 - /bin/zsh Browsers: Chrome: 126.0.6478.127 Chrome Canary: 128.0.6573.0 Safari: 17.5 npmPackages: ...
[ "https://github.com/web-infra-dev/rsbuild/commit/9eaa102706b0d8dd8dbf9877de5d75153ac14f12", "https://github.com/web-infra-dev/rsbuild/commit/4be463c225089a65bdf27189e6fcf06fb0d99db6" ]
2024-07-04T07:52:58
0.7
TypeScript
web-infra-dev/rsbuild
1,007
web-infra-dev__rsbuild-1007
[ 987 ]
d7ee4ff2e26ef9fd3122e7fee45dc0cbbc2b2cfa
diff --git a/packages/core/src/plugins/html.ts b/packages/core/src/plugins/html.ts index a41f49f968..0fe7eeb821 100644 --- a/packages/core/src/plugins/html.ts +++ b/packages/core/src/plugins/html.ts @@ -11,6 +11,7 @@ import { isHtmlDisabled, removeTailSlash, mergeChainedOptions, + isNil, } from '@rsbuild/sha...
diff --git a/e2e/cases/html/inject/index.test.ts b/e2e/cases/html/inject/index.test.ts index a22087749c..6f0e92dcfb 100644 --- a/e2e/cases/html/inject/index.test.ts +++ b/e2e/cases/html/inject/index.test.ts @@ -28,6 +28,8 @@ test('injection script order should be as expected', async () => { html.indexOf('/js/conve...
[Bug]: html.inject false not works ### Version ```sh rsbuild 0.2.5 ``` ### Details I set inject false and use custom template. expect script only inject once, but actually inject twice rsbuildConfig: ```ts rsbuildConfig: { html: { inject: false, template: './static/index.html', ...
confirmed. would you please assign to me if there's no one working on it at the moment. > confirmed. would you please assign to me if there's no one working on it at the moment. @xc2 Of course, thanks for your willingness to fix this~ will fix by today(+0800). ready for review, please check
confirmed. would you please assign to me if there's no one working on it at the moment. > confirmed. would you please assign to me if there's no one working on it at the moment. @xc2 Of course, thanks for your willingness to fix this~ will fix by today(+0800). ready for review, please check
[ "https://github.com/web-infra-dev/rsbuild/commit/8b366399e76ec81c0774f861a00a6b5f87d6cf24", "https://github.com/web-infra-dev/rsbuild/commit/ed4bbe47a21e33b19f3aff9d63d1cda646577bc5", "https://github.com/web-infra-dev/rsbuild/commit/a32bd4a5dbff475d29b67af260051a54ade6759e" ]
2023-12-19T16:49:41
0.2
TypeScript
web-infra-dev/rsbuild
729
web-infra-dev__rsbuild-729
[ 58 ]
1fd4fa80431df89fd3e3ab35728124617ba9e605
diff --git a/.changeset/gorgeous-swans-compete.md b/.changeset/gorgeous-swans-compete.md new file mode 100644 index 0000000000..1e388fd4e2 --- /dev/null +++ b/.changeset/gorgeous-swans-compete.md @@ -0,0 +1,6 @@ +--- +'@rsbuild/shared': patch +'@rsbuild/core': patch +--- + +feat(core): support printFileSize.detail and ...
diff --git a/e2e/cases/performance/printFileSize.test.ts b/e2e/cases/performance/printFileSize.test.ts new file mode 100644 index 0000000000..46d127d506 --- /dev/null +++ b/e2e/cases/performance/printFileSize.test.ts @@ -0,0 +1,79 @@ +import { join } from 'path'; +import { expect, test } from '@playwright/test'; +impor...
[Feature]: Support only print total file sizes ### What problem does this feature solve? Some users may only care about the total size, Rsbuild should support only print total file sizes, ### What does the proposed API look like? ```ts export default { performance: { printFileSize: { // whether to p...
[ "https://github.com/web-infra-dev/rsbuild/commit/beba5fa4ad8b868406f184df86c55030e7b56f34", "https://github.com/web-infra-dev/rsbuild/commit/ea67c4b5f9f4e9b823578b0484230b861a5227d7", "https://github.com/web-infra-dev/rsbuild/commit/ecea24b4c4ed1704b34f95d59ddcb57b3eb4fb32" ]
2023-11-27T11:36:47
0.1
TypeScript
web-infra-dev/rsbuild
4,717
web-infra-dev__rsbuild-4717
[ 4689 ]
7354d2c9a7d39d42fce338e960b2e642a6a8e20a
diff --git a/packages/core/src/plugins/css.ts b/packages/core/src/plugins/css.ts index 28ae9ff53b..24bf726363 100644 --- a/packages/core/src/plugins/css.ts +++ b/packages/core/src/plugins/css.ts @@ -1,9 +1,9 @@ -import path from 'node:path'; +import path, { posix } from 'node:path'; import deepmerge from 'deepmerge'; ...
diff --git a/e2e/cases/css/export-type-string/index.test.ts b/e2e/cases/css/export-type-string/index.test.ts new file mode 100644 index 0000000000..d8d96cbc34 --- /dev/null +++ b/e2e/cases/css/export-type-string/index.test.ts @@ -0,0 +1,54 @@ +import { build, dev, rspackOnlyTest } from '@e2e/helper'; +import { expect }...
[Bug]: build fails when trying to import CSS with `tools.cssLoader.exportType = 'string'` ### Version ```sh System: OS: Linux 6.12 Manjaro Linux CPU: (20) x64 Intel(R) Core(TM) i5-14600K Memory: 18.60 GB / 31.12 GB Container: Yes Shell: 5.9 - /usr/bin/zsh Browsers: Chromium: 133.0.6943.141 npmPackages: @...
This will be supported in the next release
This will be supported in the next release
[ "https://github.com/web-infra-dev/rsbuild/commit/18d734980937e4668addb6485cc567b1cb827994", "https://github.com/web-infra-dev/rsbuild/commit/ca31064512809979bab004aa102a012fc252a788", "https://github.com/web-infra-dev/rsbuild/commit/2b6684e0332a3e5d167aafe1730975c135d22438" ]
2025-03-06T02:53:45
1.0
TypeScript
payloadcms/payload
14,313
payloadcms__payload-14313
[ 14260 ]
6399635005624f399fdf766940f7b6793399f3e8
diff --git a/packages/ui/src/elements/PublishButton/index.tsx b/packages/ui/src/elements/PublishButton/index.tsx index 249ca17edad..fcecc28ed5e 100644 --- a/packages/ui/src/elements/PublishButton/index.tsx +++ b/packages/ui/src/elements/PublishButton/index.tsx @@ -170,6 +170,7 @@ export function PublishButton({ label: ...
diff --git a/test/lexical/collections/LexicalRelationships/index.ts b/test/lexical/collections/LexicalRelationships/index.ts index c71c2c5bba8..15c51203276 100644 --- a/test/lexical/collections/LexicalRelationships/index.ts +++ b/test/lexical/collections/LexicalRelationships/index.ts @@ -15,6 +15,7 @@ export const Lexi...
Relationship fields expects ID instead of object in localized LexicalEditor ### Discussed in https://github.com/payloadcms/payload/discussions/14212 <div type='discussions-op-text'> <sup>Originally posted by **Pathius** October 16, 2025</sup> In our situation we have this `richText` field ```ts export const introduc...
🚀 This is included in version [v3.61.1](https://github.com/payloadcms/payload/releases/tag/v3.61.1) This issue has been automatically locked. Please open a new issue if this issue persists with any additional detail.
[ "https://github.com/payloadcms/payload/commit/b093cb1584c08ad9937a2a1f9728fbcebe28b104" ]
2025-10-23T11:19:54
3.0
TypeScript
payloadcms/payload
3,949
payloadcms__payload-3949
[ 3945 ]
1f8f173741fd524c7c2f11cc104672854f625da9
diff --git a/packages/payload/src/admin/components/forms/RenderFields/filterFields.tsx b/packages/payload/src/admin/components/forms/RenderFields/filterFields.tsx index 472927002cd..243d6187634 100644 --- a/packages/payload/src/admin/components/forms/RenderFields/filterFields.tsx +++ b/packages/payload/src/admin/compon...
diff --git a/test/access-control/config.ts b/test/access-control/config.ts index be38197429e..8858f761572 100644 --- a/test/access-control/config.ts +++ b/test/access-control/config.ts @@ -52,7 +52,22 @@ export default buildConfigWithDefaults({ setTimeout(resolve, 50, true) // set to 'true' or 'false' here...
User with insufficient access can reassign their own roles on the front-end ### Link to reproduction https://github.com/hdodov/payload-site/tree/bug-role-access ### Describe the Bug A user without admin rights can *seemingly* change their own role to an admin. The front-end indicates that everything goes through suc...
This issue has been automatically locked. Please open a new issue if this issue persists with any additional detail.
[ "https://github.com/payloadcms/payload/commit/87376658ba21b72ed4b62dd8fca7f10f92a43610", "https://github.com/payloadcms/payload/commit/ae4e8b511c0bffce3b33f969693d6b46da3e0e65", "https://github.com/payloadcms/payload/commit/9b494a3c4397355c7f05a3867f5d808fadb52725", "https://github.com/payloadcms/payload/comm...
2023-10-31T13:57:42
3.0
TypeScript
payloadcms/payload
3,729
payloadcms__payload-3729
[ 3727 ]
58e208388206f66a1543f9717a9b8685d2e5ec1d
diff --git a/packages/payload/src/graphql/schema/buildPoliciesType.ts b/packages/payload/src/graphql/schema/buildPoliciesType.ts index 5929787fea8..999c34218fb 100644 --- a/packages/payload/src/graphql/schema/buildPoliciesType.ts +++ b/packages/payload/src/graphql/schema/buildPoliciesType.ts @@ -217,6 +217,9 @@ export ...
diff --git a/test/globals/config.ts b/test/globals/config.ts index ec6f436dfbc..00686f4be3f 100644 --- a/test/globals/config.ts +++ b/test/globals/config.ts @@ -80,6 +80,12 @@ export default buildConfigWithDefaults({ }, ], }, + { + slug: 'without-graphql', + access, + graphQL: fal...
Disabling GraphQL on a global causes Payload to generate an invalid GraphQL schema ### Link to reproduction https://github.com/diesieben07/payload/tree/issue/disable-graphql ### To Reproduce Set `graphQL: false` on a global ### Describe the Bug When GraphQL is disabled, Payload generates an invalid GraphQL schema ...
This will be released in 2.0.11 This issue has been automatically locked. Please open a new issue if this issue persists with any additional detail.
[ "https://github.com/payloadcms/payload/commit/a1628d7901600c579866fa2c9aee6011172b1b70" ]
2023-10-18T08:06:18
3.0
TypeScript
payloadcms/payload
2,438
payloadcms__payload-2438
[ 2437 ]
95719a978c7ec088f35990db09cb80c6fcf818f5
diff --git a/src/admin/components/views/collections/List/RelationshipProvider/index.tsx b/src/admin/components/views/collections/List/RelationshipProvider/index.tsx index efc7c9f742e..0a77221585c 100644 --- a/src/admin/components/views/collections/List/RelationshipProvider/index.tsx +++ b/src/admin/components/views/col...
diff --git a/test/localization/config.ts b/test/localization/config.ts index 88fd345abb4..fda878d8381 100644 --- a/test/localization/config.ts +++ b/test/localization/config.ts @@ -20,7 +20,7 @@ export type LocalizedPostAllLocale = LocalizedPost & { }; }; -export const slug = 'localized-posts'; +export const loca...
Collection List View: Relationship titles not displayed when "en" localization is not localized ### Link to reproduction https://github.com/AlessioGr/payload/tree/repro ### To Reproduce 1. Make sure you are in the "de" locale 2. Create a document in the "Posts" and a document in the "Collection2s" collection....
Bumping this for support, related PR is open and ready for review. Hey @ssyberg got around to reviewing, that has been merged in! Thanks again @AlessioGr 👍 Will be released in the next version. Woot! This issue has been automatically locked. Please open a new issue if this issue persists with any additional detail...
[ "https://github.com/payloadcms/payload/commit/b6f70c32c8d870ef6badaa42d3f0662b66251af3", "https://github.com/payloadcms/payload/commit/2bfa45b31d4e6ae55d7e0e82cc5277bdd3bb16d4", "https://github.com/payloadcms/payload/commit/977f79f2af9a79eb35f0ceff5593eeb458cd4eec", "https://github.com/payloadcms/payload/comm...
2023-04-02T21:03:07
3.0
TypeScript
payloadcms/payload
4,464
payloadcms__payload-4464
[ 4081, 4227 ]
77ebba3ccddb806c11ab8910e0934e4f4c6aa138
diff --git a/packages/db-mongodb/src/queries/buildSearchParams.ts b/packages/db-mongodb/src/queries/buildSearchParams.ts index 59df2b770c6..91ca73cf45a 100644 --- a/packages/db-mongodb/src/queries/buildSearchParams.ts +++ b/packages/db-mongodb/src/queries/buildSearchParams.ts @@ -92,7 +92,7 @@ export async function bui...
diff --git a/test/admin/collections/Posts.ts b/test/admin/collections/Posts.ts index 32bba0dbc5e..13c6cd7a2bb 100644 --- a/test/admin/collections/Posts.ts +++ b/test/admin/collections/Posts.ts @@ -15,7 +15,7 @@ export const Posts: CollectionConfig = { }, admin: { description: 'Description', - listSearchab...
ID not working in listSearchableFields ### Link to reproduction pnpm dev admin ### Describe the Bug If `id` is included in `listSearchableFields`, the expected result is not returned. ### To Reproduce Using the monorepo, 1. Add `id` to `listSearchableFields` in `test/admin/collections/Posts.ts` 2. `pnpm dev ad...
I've been having the same issue as in this related bug-report: [#4227](https://github.com/payloadcms/payload/issues/4227) Any updates to this? A little extra detail: This only seems to be an issue when searching by ID on collections whose ID's are created automatically by Payload. I have several collections where th...
I've been having the same issue as in this related bug-report: [#4227](https://github.com/payloadcms/payload/issues/4227) Any updates to this? A little extra detail: This only seems to be an issue when searching by ID on collections whose ID's are created automatically by Payload. I have several collections where th...
[ "https://github.com/payloadcms/payload/commit/2e1fdaf3bf4b07e53442205fd74c4ee461eb26e3", "https://github.com/payloadcms/payload/commit/d22fe40fd86e032b50628a7e67528161708bda09" ]
2023-12-12T17:27:47
3.0
TypeScript
TanStack/form
501
TanStack__form-501
[ 502 ]
665894708c4057120c10d74ee953dec293a286c9
diff --git a/packages/form-core/src/FieldApi.ts b/packages/form-core/src/FieldApi.ts index ff718dbe4..418719d1c 100644 --- a/packages/form-core/src/FieldApi.ts +++ b/packages/form-core/src/FieldApi.ts @@ -243,6 +243,7 @@ export class FieldApi< unsubscribe() if (!preserveValue) { delete info.insta...
diff --git a/packages/form-core/src/tests/FieldApi.spec.ts b/packages/form-core/src/tests/FieldApi.spec.ts index 30bfdeb3a..04698a46f 100644 --- a/packages/form-core/src/tests/FieldApi.spec.ts +++ b/packages/form-core/src/tests/FieldApi.spec.ts @@ -601,5 +601,9 @@ describe('field api', () => { const info = form.ge...
Unmounting a field does not update the form ### Describe the bug Hi, I just noticed a bug unmounting a field: the state and fieldInfo of the field is preserved in the form even after unmounting it. To illustrate I added some expects to the `unmount` test: ```js // Field should have been removed from the ...
@crutchcorn can you please reopen this? seems it is not fully fixed.
[ "https://github.com/TanStack/form/commit/28a9a4f9478e6fdede4e1b1803819331e98490ad", "https://github.com/TanStack/form/commit/37decf8c41b3114314f8b01e489a51945a0ba048", "https://github.com/TanStack/form/commit/008f36fa75f9e1e2b455319bef5e7adf6694bc2b", "https://github.com/TanStack/form/commit/cc92627481c26f880...
2023-11-02T22:00:24
0.0
TypeScript
TanStack/form
739
TanStack__form-739
[ 738 ]
4879e324ec0c87c978d4276d590c680f4c8470f1
diff --git a/packages/form-core/src/util-types.ts b/packages/form-core/src/util-types.ts index 29f238527..25dd9f61b 100644 --- a/packages/form-core/src/util-types.ts +++ b/packages/form-core/src/util-types.ts @@ -60,7 +60,7 @@ type PrefixTupleAccessor< }[TIndex] type PrefixObjectAccessor<T extends object, TDepth ex...
diff --git a/packages/form-core/src/tests/util-types.test-d.ts b/packages/form-core/src/tests/util-types.test-d.ts index ae07663a2..999511776 100644 --- a/packages/form-core/src/tests/util-types.test-d.ts +++ b/packages/form-core/src/tests/util-types.test-d.ts @@ -41,6 +41,18 @@ assertType< | 'meta.mainUser.age' >(...
DeepKeys type not working with all partial object ### Describe the bug `DeepKeys` not working with all partial object, expect returns object keys, but returns `string`. ### Your minimal, reproducible example see Steps to reproduce ### Steps to reproduce ```ts import type { DeepKeys } from "@tanstack/react-form"; ...
Thanks! Adding one more case I found with one partial nested field: ```ts type NestedPartialObject = { c: { c1?: string c2: string } } // "c" | "cundefined" | "c.c1" | "c.c2" type PartPartialObjectKeys = DeepKeys<NestedPartialObject> ```
Thanks! Adding one more case I found with one partial nested field: ```ts type NestedPartialObject = { c: { c1?: string c2: string } } // "c" | "cundefined" | "c.c1" | "c.c2" type PartPartialObjectKeys = DeepKeys<NestedPartialObject> ```
[ "https://github.com/TanStack/form/commit/3215e103f40bb549822ff8a0599cf5d386c1fa51" ]
2024-06-06T10:35:01
0.0
TypeScript
TanStack/form
1,370
TanStack__form-1370
[ 1323 ]
527c19a5cc0ebd32da88756bf581cca1d2c2e0b5
diff --git a/packages/form-core/src/FieldApi.ts b/packages/form-core/src/FieldApi.ts index a95fd5515..18940ac2a 100644 --- a/packages/form-core/src/FieldApi.ts +++ b/packages/form-core/src/FieldApi.ts @@ -4,7 +4,12 @@ import { standardSchemaValidators, } from './standardSchemaValidator' import { defaultFieldMeta }...
diff --git a/packages/form-core/tests/FieldApi.spec.ts b/packages/form-core/tests/FieldApi.spec.ts index 9d03a23c8..a9fb317bf 100644 --- a/packages/form-core/tests/FieldApi.spec.ts +++ b/packages/form-core/tests/FieldApi.spec.ts @@ -62,6 +62,7 @@ describe('field api', () => { isDirty: false, errors: [], ...
"Cannot read properties of undefined" when removing array field ### Describe the bug When removing elements from array using the removeFieldValue api, we sometimes receive: ``` Uncaught (in promise) TypeError: Cannot read properties of undefined (reading 'errorMap') ``` I am able to reproduce this when removing an el...
Determined that this issue actually plagues all validations post array shifting/inserting/moving/removing.... I have opened #1324 to resolve this in a much cleaner way. I'm having the same issue. Hope you guys like this approach, it'll allow us to fix the issue without a breaking change. Long term we may want to upda...
Determined that this issue actually plagues all validations post array shifting/inserting/moving/removing.... I have opened #1324 to resolve this in a much cleaner way. I'm having the same issue. Hope you guys like this approach, it'll allow us to fix the issue without a breaking change. Long term we may want to upda...
[ "https://github.com/TanStack/form/commit/35d3c97de8f34bdb6b03580e3981eaa8d10cc2eb" ]
2025-04-03T00:40:35
0.0
TypeScript
TanStack/form
475
TanStack__form-475
[ 464 ]
d739f2a064a62b71d2296766b04e8935ba93916a
diff --git a/packages/form-core/src/FormApi.ts b/packages/form-core/src/FormApi.ts index 862e2fa2b..678267546 100644 --- a/packages/form-core/src/FormApi.ts +++ b/packages/form-core/src/FormApi.ts @@ -134,8 +134,10 @@ export class FormApi<TFormData, ValidatorType> { (field) => field?.isValidating, ...
diff --git a/packages/form-core/src/tests/FormApi.spec.ts b/packages/form-core/src/tests/FormApi.spec.ts index 9d8fdaf4f..e6ff6ba00 100644 --- a/packages/form-core/src/tests/FormApi.spec.ts +++ b/packages/form-core/src/tests/FormApi.spec.ts @@ -1,6 +1,7 @@ import { expect } from 'vitest' import { FormApi } from '.....
form.Subscribe is only re-rendered if input length > 1 ### Describe the bug As soon as the input validation fails the first time, the children of form.Subscribe are only re-rendered with the correct value of `canSubmit` if the input length is longer than 1 character. ### Your minimal, reproducible example https://...
[ "https://github.com/TanStack/form/commit/f8bc870dcf58c9c61a361a957e6a7ed0a635f527" ]
2023-10-18T10:20:22
0.0
TypeScript
TanStack/form
1,697
TanStack__form-1697
[ 1696 ]
22c49dc8726ae8255e3e60a2a72124af46b08886
diff --git a/.changeset/brown-cars-smell.md b/.changeset/brown-cars-smell.md new file mode 100644 index 000000000..6532c7351 --- /dev/null +++ b/.changeset/brown-cars-smell.md @@ -0,0 +1,5 @@ +--- +'@tanstack/form-core': patch +--- + +fix(form-core): call `onSubmitInvalid` even when `canSubmit` is false diff --git a/pa...
diff --git a/packages/form-core/tests/FormApi.spec.ts b/packages/form-core/tests/FormApi.spec.ts index 3639ea7d6..901aa6dee 100644 --- a/packages/form-core/tests/FormApi.spec.ts +++ b/packages/form-core/tests/FormApi.spec.ts @@ -3156,6 +3156,32 @@ describe('form api', () => { await form.handleSubmit() }) + i...
`form.onSubmitInvalid` not called when `canSubmit` is false ### Describe the bug When `handleSubmit` is called while `canSubmit` is `false` an early return is hit and `onSubmitInvalid` is not called. https://github.com/TanStack/form/blob/1e58e57987e4f79fb23d0034d1cdceebb9a7299b/packages/form-core/src/FormApi.ts#L1918...
[ "https://github.com/TanStack/form/commit/c70ec04778e3065bb2632b5e77b7618be1549dca", "https://github.com/TanStack/form/commit/7a8b6b289f9401e5114a0e8ae6135358ff22544e", "https://github.com/TanStack/form/commit/c8db95a77845fb68b79cea133758c952961252ae", "https://github.com/TanStack/form/commit/15705d6987ac65712...
2025-08-15T15:05:20
0.0
TypeScript
astral-sh/uv
14,152
astral-sh__uv-14152
[ 13921 ]
a9a9e714819df970ccaa8af7651fa2d1f97a3672
diff --git a/Cargo.lock b/Cargo.lock index a30a0cbe15432..095ba90c1370c 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -5176,6 +5176,7 @@ dependencies = [ "uv-pypi-types", "uv-redacted", "uv-small-str", + "uv-warnings", "version-ranges", ] diff --git a/crates/uv-cli/src/lib.rs b/crates/uv-cli/src/lib.rs index b...
diff --git a/crates/uv/tests/it/edit.rs b/crates/uv/tests/it/edit.rs index d117b1e8c9f5b..59547d34b97b8 100644 --- a/crates/uv/tests/it/edit.rs +++ b/crates/uv/tests/it/edit.rs @@ -9364,7 +9364,7 @@ fn add_index_with_existing_relative_path_index() -> Result<()> { let wheel_dst = packages.child("ok-1.0.0-py3-none-a...
Improve error for `--index <name>` when a name of an existing index is used The current message (added in #13917) is: ``` error: Directory not found for index: file://path/to/index ``` We can make this more informative, particularly since the user may have intended to specify a named index instead of a URL.
My comment on #13917 was specifically for the case where the named index exists. We might always want to error here, regardless of whether the directory exists? Or require the user to disambiguate with `./<path>`? I'd prefer requiring something that explicitly disambiguates paths from names, such as the `./path`.
My comment on #13917 was specifically for the case where the named index exists. We might always want to error here, regardless of whether the directory exists? Or require the user to disambiguate with `./<path>`? I'd prefer requiring something that explicitly disambiguates paths from names, such as the `./path`.
[ "https://github.com/astral-sh/uv/commit/e9df9bed5f82ee879384732aeb285d3a60bd0dfd", "https://github.com/astral-sh/uv/commit/af2b605197ae39da70f39e3f50bc733f6ff62238" ]
2025-06-20T13:53:59
0.4
Rust
astral-sh/uv
297
astral-sh__uv-297
[ 296 ]
a4002fe13228fea2e52c1a6af77a5cccfb44c706
diff --git a/crates/puffin-git/src/git.rs b/crates/puffin-git/src/git.rs index ebc43b3d3014b..a2d2426c04220 100644 --- a/crates/puffin-git/src/git.rs +++ b/crates/puffin-git/src/git.rs @@ -15,12 +15,40 @@ use tracing::{debug, info, warn}; use url::Url; use crate::util::retry; -use crate::{FetchStrategy, GitReferenc...
diff --git a/crates/puffin-cli/tests/pip_compile.rs b/crates/puffin-cli/tests/pip_compile.rs index b337dd122c275..d4d9bf90aad42 100644 --- a/crates/puffin-cli/tests/pip_compile.rs +++ b/crates/puffin-cli/tests/pip_compile.rs @@ -637,6 +637,168 @@ fn compile_git_https_dependency() -> Result<()> { Ok(()) } +/// R...
Add support for Git revision references in VCS URLs See: https://pip.pypa.io/en/stable/topics/vcs-support. We need to support, e.g., `MyProject @ git+https://git.example.com/MyProject.git@v1.0`. I didn't realize that pip expects a different format here than Cargo, which uses query parameters.
[ "https://github.com/astral-sh/uv/commit/5e38f45fa9ddd9f3c7e66e023ecb0769cc68fe1f" ]
2023-11-02T18:45:49
0.0
Rust
astral-sh/uv
6,585
astral-sh__uv-6585
[ 6511 ]
6c62d9fbf1f591da0a7599f3bd8afba1110229a0
diff --git a/crates/uv-cli/src/lib.rs b/crates/uv-cli/src/lib.rs index b68666f2c04ae..ea67833743f9a 100644 --- a/crates/uv-cli/src/lib.rs +++ b/crates/uv-cli/src/lib.rs @@ -2099,11 +2099,12 @@ pub struct InitArgs { #[arg(long)] pub name: Option<PackageName>, - /// Create a virtual workspace instead of a ...
diff --git a/crates/uv/tests/common/mod.rs b/crates/uv/tests/common/mod.rs index d8e4f8daa7d88..ec187573b3189 100644 --- a/crates/uv/tests/common/mod.rs +++ b/crates/uv/tests/common/mod.rs @@ -1110,8 +1110,9 @@ pub fn make_project(dir: &Path, name: &str, body: &str) -> anyhow::Result<()> { {body} [b...
Add first-class support for virtual projects A lot of users don't want to structure their projects as valid Python packages -- perhaps they're creating a web application, or a collection of scripts, etc. These all _can_ be structured as valid Python packages, but users tend not to do this. Requiring that projects are v...
There's an argument to be made that this should be the _default_ if you don't define a build system. I'm also open to that. I am going to prototype this later today. Thanks Charlie. This will definitely help users working in monorepos and legacy codebases that contain many nested packages/scripts without clear boundari...
There's an argument to be made that this should be the _default_ if you don't define a build system. I'm also open to that. I am going to prototype this later today. Thanks Charlie. This will definitely help users working in monorepos and legacy codebases that contain many nested packages/scripts without clear boundari...
[ "https://github.com/astral-sh/uv/commit/ecd9555c6c932565fb0967c0951b47390fa4d745", "https://github.com/astral-sh/uv/commit/0506221dccb68de88c04dbe1a048938becd35d48" ]
2024-08-24T16:03:38
0.3
Rust
astral-sh/uv
4,951
astral-sh__uv-4951
[ 4671 ]
aa8f126f137a97ebe4a3887ad229409e85ea4cca
diff --git a/Cargo.lock b/Cargo.lock index 18d0531a6d628..ae51e1cf6f060 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -4475,6 +4475,7 @@ dependencies = [ "regex", "reqwest", "rustc-hash 2.0.0", + "same-file", "serde", "serde_json", "textwrap", diff --git a/crates/uv/Cargo.toml b/crates/uv/Cargo.toml index 491...
diff --git a/crates/uv/tests/tool_install.rs b/crates/uv/tests/tool_install.rs index 7ee1f36bfb543..798f500b323cf 100644 --- a/crates/uv/tests/tool_install.rs +++ b/crates/uv/tests/tool_install.rs @@ -26,7 +26,8 @@ fn tool_install() { uv_snapshot!(context.filters(), context.tool_install() .arg("black") ...
`uv tool` commands should warn if the executable directory isn't on the `PATH` e.g. during `uv tool install` where the executable entry points are placed. We can also consider some command in the style of `pipx ensurepath` that adds the executable directory the user's shell configuration.
[ "https://github.com/astral-sh/uv/commit/b893e38f8e6f5ba050fb5d2097684dc05610bc46" ]
2024-07-10T02:01:19
0.2
Rust
astral-sh/uv
2,926
astral-sh__uv-2926
[ 2852 ]
a01143980ab4073cc31f071c7c013e027483b31b
diff --git a/crates/distribution-types/src/lib.rs b/crates/distribution-types/src/lib.rs index 4b84e6e38a704..6c2ad6c81c458 100644 --- a/crates/distribution-types/src/lib.rs +++ b/crates/distribution-types/src/lib.rs @@ -371,6 +371,14 @@ impl Dist { } } + /// Returns the [`IndexUrl`], if the distribu...
diff --git a/crates/uv/tests/pip_compile.rs b/crates/uv/tests/pip_compile.rs index 292d4507bdfe3..1f82bc1887387 100644 --- a/crates/uv/tests/pip_compile.rs +++ b/crates/uv/tests/pip_compile.rs @@ -7334,3 +7334,149 @@ fn compile_index_url_fallback_prefer_primary() -> Result<()> { Ok(()) } + +/// Ensure that `--e...
Annotate the index from which a package is pulled in `uv pip compile` Awaiting that #171 gets resolved, it would be very useful if `uv pip compile` could generate annotations with the “source” index. Currently `uv pip compile --extra-index-url <MYINDEX> --no-header <(echo MYPACKAGE)` outputs something like ``` DEP...
Technically, we could do this without #171. We know which index each package comes from at compile-time. > Technically, we could do this without #171. We know which index each package comes from at compile-time. Sorry for my unclear wording: indeed I'm suggesting to implent this enhancement as a mitigation for possi...
Technically, we could do this without #171. We know which index each package comes from at compile-time. > Technically, we could do this without #171. We know which index each package comes from at compile-time. Sorry for my unclear wording: indeed I'm suggesting to implent this enhancement as a mitigation for possi...
[ "https://github.com/astral-sh/uv/commit/a068b5f9cacfe19aa8694554441905e50b4a2a38", "https://github.com/astral-sh/uv/commit/296000fc68e5cdf236da098ac49757a98e199553", "https://github.com/astral-sh/uv/commit/d7ef99bd3a3d7965b61cc585a8fdda707e7ac19c", "https://github.com/astral-sh/uv/commit/da4fa226e43e1f7b6c272...
2024-04-09T04:14:44
0.1
Rust
noir-lang/noir
1,598
noir-lang__noir-1598
[ 1537 ]
f2d6b7bd8c909cbe85c8b5ff760ac2a4607ab56e
diff --git a/Cargo.lock b/Cargo.lock index 1fa151a51f0..c8790acc1b1 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -1934,6 +1934,7 @@ dependencies = [ "noir_lsp", "noirc_abi", "noirc_driver", + "noirc_errors", "noirc_frontend", "predicates 2.1.5", "rustc_version", @@ -1997,7 +1998,6 @@ dependencies = [ "acvm...
diff --git a/crates/nargo_cli/src/cli/test_cmd.rs b/crates/nargo_cli/src/cli/test_cmd.rs index e4fadfa41c5..ebb83bd2aa1 100644 --- a/crates/nargo_cli/src/cli/test_cmd.rs +++ b/crates/nargo_cli/src/cli/test_cmd.rs @@ -4,6 +4,7 @@ use acvm::{acir::native_types::WitnessMap, Backend}; use clap::Args; use nargo::ops::exec...
Move printing errors to nargo_cli ### Problem Currently errors are printed in noirc_driver to stdout, which is counter-intuitive for a crate that should be a library. ### Happy Case We can move the printing of errors to `nargo_cli` instead ### Alternatives Considered _No response_ ### Additional Context _No resp...
I will take care of it. Do I need to remove the printing from those places, right? https://github.com/noir-lang/noir/blob/ae7ac21a796171e8e6c28b3184cc744788d9ecaa/crates/noirc_driver/src/lib.rs#L194-L200 https://github.com/noir-lang/noir/blob/ae7ac21a796171e8e6c28b3184cc744788d9ecaa/crates/noirc_driver/src/lib.rs#L...
I will take care of it. Do I need to remove the printing from those places, right? https://github.com/noir-lang/noir/blob/ae7ac21a796171e8e6c28b3184cc744788d9ecaa/crates/noirc_driver/src/lib.rs#L194-L200 https://github.com/noir-lang/noir/blob/ae7ac21a796171e8e6c28b3184cc744788d9ecaa/crates/noirc_driver/src/lib.rs#L...
[ "https://github.com/noir-lang/noir/commit/95498ed2d03394a7b08cef8ba5bc4ac5cf8d47b2", "https://github.com/noir-lang/noir/commit/d224e7e6cf52a569236317779109784e47389374", "https://github.com/noir-lang/noir/commit/f687fbb20a8da7acc42dd3d44a74f51b411bec3d", "https://github.com/noir-lang/noir/commit/0f2276778e598...
2023-06-07T22:23:41
0.0
Rust
noir-lang/noir
6,269
noir-lang__noir-6269
[ 6263 ]
35dedb54a0853ba0fa85038d832a520f9ba01a98
diff --git a/Cargo.lock b/Cargo.lock index aca7f199bb5..936aa636e86 100644 --- a/Cargo.lock +++ b/Cargo.lock @@ -2840,7 +2840,7 @@ dependencies = [ "num-bigint", "num-traits", "proptest", - "proptest-derive", + "proptest-derive 0.4.0", "serde", "serde_json", "strum", @@ -2961,6 +2961,8 @@ dependencies = [ ...
diff --git a/compiler/noirc_frontend/proptest-regressions/tests/arithmetic_generics.txt b/compiler/noirc_frontend/proptest-regressions/tests/arithmetic_generics.txt new file mode 100644 index 00000000000..80f5c7f1ead --- /dev/null +++ b/compiler/noirc_frontend/proptest-regressions/tests/arithmetic_generics.txt @@ -0,0 ...
Proptest arithmetic generics ### Problem Arithmetic generics have gotten more complex recently and we only have a handful of unit tests to check them. This seems insufficient since we have 5 `BinaryTypeOperator`'s, rules involving pairs of operators, and at least two conditions for simplification (`== 0` and `divide...
[ "https://github.com/noir-lang/noir/commit/4d3b48cf7dfeac261217c5ab8de10f513e901cea", "https://github.com/noir-lang/noir/commit/7d2653caada9c1550c5a91145cb31d4f8d7f4f5e", "https://github.com/noir-lang/noir/commit/420f94353899033188a67d5c537ab91d3b7f963e", "https://github.com/noir-lang/noir/commit/b0ab542e08ec1...
2024-10-10T11:42:38
0.0
Rust
noir-lang/noir
7,026
noir-lang__noir-7026
[ 6571, 7039 ]
18ea0515c47b65fa8e599cc22b1772619ae69b2e
diff --git a/compiler/noirc_frontend/src/elaborator/mod.rs b/compiler/noirc_frontend/src/elaborator/mod.rs index 0f59de60047..d263c8245f8 100644 --- a/compiler/noirc_frontend/src/elaborator/mod.rs +++ b/compiler/noirc_frontend/src/elaborator/mod.rs @@ -315,7 +315,7 @@ impl<'context> Elaborator<'context> { se...
diff --git a/compiler/noirc_frontend/src/tests.rs b/compiler/noirc_frontend/src/tests.rs index c1b86b5dcf7..637b15e7197 100644 --- a/compiler/noirc_frontend/src/tests.rs +++ b/compiler/noirc_frontend/src/tests.rs @@ -3955,3 +3955,26 @@ fn mutable_self_call() { "#; assert_no_errors(src); } + +#[test] +fn chec...
Traits with associated types can't be used in `where` clauses ### Aim Given a simple trait with an associated type: ```noir trait Foo { type Bar; } ``` I attempted to require `Foo` in a `where` clause in three ways: 1. ```noir // using "where (): Foo" fails with the same error, // even if the following impl is...
This is expected currently while the feature is incomplete - the only thing we've shipped so far is an explicit version where associated types must always be specified. So I'd expect the following to work: ```noir fn foo<T, U>(x: T) where T: Foo<Bar = U> { } ``` (we should keep this issue until associated types are f...
This is expected currently while the feature is incomplete - the only thing we've shipped so far is an explicit version where associated types must always be specified. So I'd expect the following to work: ```noir fn foo<T, U>(x: T) where T: Foo<Bar = U> { } ``` (we should keep this issue until associated types are f...
[ "https://github.com/noir-lang/noir/commit/555d27da71fe9a514a9528df475adcfeaf6d0c0c", "https://github.com/noir-lang/noir/commit/ea59862a788f8332551a18d73e6ae3d74e27cfbf", "https://github.com/noir-lang/noir/commit/f1ef945a1e1e9207d1e273526d597e9baa4a3e0d", "https://github.com/noir-lang/noir/commit/4a59194a9848e...
2025-01-10T18:10:34
0.0
Rust
noir-lang/noir
7,526
noir-lang__noir-7526
[ 7455 ]
3869fe933e5c315b57b991b5a54636c44ec3856e
diff --git a/compiler/noirc_frontend/src/ast/statement.rs b/compiler/noirc_frontend/src/ast/statement.rs index ae7f0bef150..c44bfa6389c 100644 --- a/compiler/noirc_frontend/src/ast/statement.rs +++ b/compiler/noirc_frontend/src/ast/statement.rs @@ -505,7 +505,11 @@ impl PathSegment { /// /// Returns an empty ...
diff --git a/compiler/noirc_frontend/src/tests.rs b/compiler/noirc_frontend/src/tests.rs index d758ad58d31..52f96c69c44 100644 --- a/compiler/noirc_frontend/src/tests.rs +++ b/compiler/noirc_frontend/src/tests.rs @@ -16,22 +16,16 @@ mod visibility; // XXX: These tests repeat a lot of code // what we should do is have...
Improve testing error locations Right now in the compiler's frontend tests we just check that expected errors happen. However, we don't check **where** they happen. One way to do this would be in a way similar to how it's done in parser tests: https://github.com/noir-lang/noir/blob/8783e480a39efb47c7783c68b0e09c1c65b...
[ "https://github.com/noir-lang/noir/commit/0857654b76acdeb358cddf7f7d02ba6f12b7c8f3", "https://github.com/noir-lang/noir/commit/7a45a29ac242f667fe931bbe1248c29d7439194e", "https://github.com/noir-lang/noir/commit/543ccba3fa72413fa3449757057199ef37198bc5", "https://github.com/noir-lang/noir/commit/241960af6cfcd...
2025-02-25T23:34:03
0.0
Rust
noir-lang/noir
8,097
noir-lang__noir-8097
[ 7287 ]
28250eac56cf1717e8bea1a2bbdc75499832664b
diff --git a/compiler/noirc_driver/src/lib.rs b/compiler/noirc_driver/src/lib.rs index 6c28a4e4af6..7c098e1a5d1 100644 --- a/compiler/noirc_driver/src/lib.rs +++ b/compiler/noirc_driver/src/lib.rs @@ -687,7 +687,6 @@ pub fn compile_no_check( force_compile: bool, ) -> Result<CompiledProgram, CompileError> { l...
diff --git a/compiler/noirc_frontend/src/ownership/tests.rs b/compiler/noirc_frontend/src/ownership/tests.rs new file mode 100644 index 00000000000..1ba46e81053 --- /dev/null +++ b/compiler/noirc_frontend/src/ownership/tests.rs @@ -0,0 +1,115 @@ +#![cfg(test)] +//! The easiest way to test this pass is a bit indirect. W...
Rework `inc_rc`, `dec_rc` and how arrays are handled in brillig in general ### Problem `inc_rc` and `dec_rc` are a common source of bugs in SSA code generated by the compiler. They require special handling since they are effectively implicit variables attached to each array in unconstrained code. ### Happy Case Now ...
Just to make sure I understand, you're not suggesting that `inc_rc` will disappear from the code, but rather that instead of figuring out which array it needs to act on, with the ref count being an internal part of the array in the Brillig VM, it will instead be like the length of a BoundedVec, a number passed around i...
Just to make sure I understand, you're not suggesting that `inc_rc` will disappear from the code, but rather that instead of figuring out which array it needs to act on, with the ref count being an internal part of the array in the Brillig VM, it will instead be like the length of a BoundedVec, a number passed around i...
[ "https://github.com/noir-lang/noir/commit/12f65c014e9bb265e00efcf96a73ed25d59bd796", "https://github.com/noir-lang/noir/commit/2562ef286f515319a3506a163ffe9704b0a1d7e4", "https://github.com/noir-lang/noir/commit/aeff5d2d956331249e9583b8fda0c1900e294edc", "https://github.com/noir-lang/noir/commit/582a40860e882...
2025-04-15T19:23:12
0.0
Rust